chore: Add tests for LLMClientInterface (#131)

.github/workflows/build_cmake.yml

@@ -80,7 +80,7 @@ jobs:
           execute_process(
             COMMAND sudo apt install
               # build dependencies
-              libgl1-mesa-dev libgtest-dev
+              libgl1-mesa-dev libgtest-dev libgmock-dev
               # runtime dependencies for tests (Qt is downloaded outside package manager,
               # thus minimal dependencies must be installed explicitly)
               libsecret-1-0 libxcb-cursor0 libxcb-icccm4 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-render0

CMakeLists.txt

@@ -11,7 +11,7 @@ set(CMAKE_CXX_EXTENSIONS OFF)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 
 find_package(QtCreator REQUIRED COMPONENTS Core)
-find_package(Qt6 COMPONENTS Core Gui Quick Widgets Network REQUIRED)
+find_package(Qt6 COMPONENTS Core Gui Quick Widgets Network Test REQUIRED)
 find_package(GTest)
 
 # IDE_VERSION is defined by QtCreator package

LLMClientInterface.hpp

@@ -58,9 +58,11 @@ class LLMClientInterface : public LanguageClient::BaseClientInterface
 
     void handleCompletion(const QJsonObject &request);
 
+    // exposed for tests
+    void sendData(const QByteArray &data) override;
+
 protected:
     void startImpl() override;
-    void sendData(const QByteArray &data) override;
     void parseCurrentMessage() override;
 
 private:

test/CMakeLists.txt

@@ -1,16 +1,22 @@
 add_executable(QodeAssistTest
     ../CodeHandler.cpp
+    ../LLMClientInterface.cpp
     CodeHandlerTest.cpp
     DocumentContextReaderTest.cpp
+    LLMClientInterfaceTests.cpp
     unittest_main.cpp
 )
 
 target_link_libraries(QodeAssistTest PRIVATE
     Qt::Core
+    Qt::Test
     GTest::GTest
+    GTest::gmock
     GTest::Main
     QtCreator::LanguageClient
     Context
 )
 
+target_compile_definitions(QodeAssistTest PRIVATE CMAKE_CURRENT_SOURCE_DIR="${CMAKE_CURRENT_SOURCE_DIR}")
+
 add_test(NAME QodeAssistTest COMMAND QodeAssistTest)

test/LLMClientInterfaceTests.cpp

@@ -0,0 +1,336 @@
+/*
+ * Copyright (C) 2025 Povilas Kanapickas
+ *
+ * This file is part of QodeAssist.
+ *
+ * QodeAssist is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * QodeAssist is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with QodeAssist. If not, see <https://www.gnu.org/licenses/>.
+ */
+
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+
+#include <QJsonArray>
+#include <QJsonDocument>
+#include <QJsonObject>
+#include <QSignalSpy>
+
+#include "LLMClientInterface.hpp"
+#include "MockDocumentReader.hpp"
+#include "MockRequestHandler.hpp"
+#include "llmcore/IPromptProvider.hpp"
+#include "llmcore/IProviderRegistry.hpp"
+#include "logger/EmptyRequestPerformanceLogger.hpp"
+#include "settings/CodeCompletionSettings.hpp"
+#include "settings/GeneralSettings.hpp"
+#include "templates/Templates.hpp"
+#include <coreplugin/editormanager/documentmodel.h>
+
+using namespace testing;
+
+namespace QodeAssist {
+
+class MockPromptProvider : public LLMCore::IPromptProvider
+{
+public:
+    MOCK_METHOD(LLMCore::PromptTemplate *, getTemplateByName, (const QString &), (const override));
+    MOCK_METHOD(QStringList, templatesNames, (), (const override));
+    MOCK_METHOD(QStringList, getTemplatesForProvider, (LLMCore::ProviderID id), (const override));
+};
+
+class MockProviderRegistry : public LLMCore::IProviderRegistry
+{
+public:
+    MOCK_METHOD(LLMCore::Provider *, getProviderByName, (const QString &), (override));
+    MOCK_METHOD(QStringList, providersNames, (), (const override));
+};
+
+class MockProvider : public LLMCore::Provider
+{
+public:
+    QString name() const override { return "mock_provider"; }
+    QString url() const override { return "https://mock_url"; }
+    QString completionEndpoint() const override { return "/v1/completions"; }
+    QString chatEndpoint() const override { return "/v1/chat/completions"; }
+    bool supportsModelListing() const override { return false; }
+
+    void prepareRequest(
+        QJsonObject &request,
+        LLMCore::PromptTemplate *promptTemplate,
+        LLMCore::ContextData context,
+        LLMCore::RequestType requestType) override
+    {
+        promptTemplate->prepareRequest(request, context);
+    }
+
+    bool handleResponse(QNetworkReply *reply, QString &accumulatedResponse) override
+    {
+        return true;
+    }
+
+    QList<QString> getInstalledModels(const QString &url) override { return {}; }
+
+    QStringList validateRequest(
+        const QJsonObject &request, LLMCore::TemplateType templateType) override
+    {
+        return {};
+    }
+
+    QString apiKey() const override { return "mock_api_key"; }
+    void prepareNetworkRequest(QNetworkRequest &request) const override {}
+    LLMCore::ProviderID providerID() const override { return LLMCore::ProviderID::OpenAI; }
+};
+
+class LLMClientInterfaceTest : public Test
+{
+protected:
+    void SetUp() override
+    {
+        Core::DocumentModel::init();
+
+        m_provider = std::make_unique<MockProvider>();
+        m_fimTemplate = std::make_unique<Templates::CodeLlamaQMLFim>();
+        m_chatTemplate = std::make_unique<Templates::Claude>();
+        m_requestHandler = std::make_unique<LLMCore::MockRequestHandler>(m_client.get());
+
+        ON_CALL(m_providerRegistry, getProviderByName(_)).WillByDefault(Return(m_provider.get()));
+        ON_CALL(m_promptProvider, getTemplateByName(_)).WillByDefault(Return(m_fimTemplate.get()));
+
+        EXPECT_CALL(m_providerRegistry, getProviderByName(_)).Times(testing::AnyNumber());
+        EXPECT_CALL(m_promptProvider, getTemplateByName(_)).Times(testing::AnyNumber());
+
+        m_generalSettings.ccProvider.setValue("mock_provider");
+        m_generalSettings.ccModel.setValue("mock_model");
+        m_generalSettings.ccTemplate.setValue("mock_template");
+        m_generalSettings.ccUrl.setValue("http://localhost:8000");
+
+        m_completeSettings.systemPromptForNonFimModels.setValue("system prompt non fim");
+        m_completeSettings.systemPrompt.setValue("system prompt");
+        m_completeSettings.userMessageTemplateForCC.setValue(
+            "user message template prefix:\n${prefix}\nsuffix:\n${suffix}\n");
+
+        m_client = std::make_unique<LLMClientInterface>(
+            m_generalSettings,
+            m_completeSettings,
+            m_providerRegistry,
+            &m_promptProvider,
+            *m_requestHandler,
+            m_documentReader,
+            m_performanceLogger);
+    }
+
+    void TearDown() override { Core::DocumentModel::destroy(); }
+
+    QJsonObject createInitializeRequest()
+    {
+        QJsonObject request;
+        request["jsonrpc"] = "2.0";
+        request["id"] = "init-1";
+        request["method"] = "initialize";
+        return request;
+    }
+
+    QString buildTestFilePath() { return QString(CMAKE_CURRENT_SOURCE_DIR) + "/test_file.py"; }
+
+    QJsonObject createCompletionRequest()
+    {
+        QJsonObject position;
+        position["line"] = 2;
+        position["character"] = 5;
+
+        QJsonObject doc;
+        // change next line to link to test_file.py in current directory of the cmake project
+        doc["uri"] = "file://" + buildTestFilePath();
+        doc["position"] = position;
+
+        QJsonObject params;
+        params["doc"] = doc;
+
+        QJsonObject request;
+        request["jsonrpc"] = "2.0";
+        request["id"] = "completion-1";
+        request["method"] = "getCompletionsCycling";
+        request["params"] = params;
+
+        return request;
+    }
+
+    QJsonObject createCancelRequest(const QString &idToCancel)
+    {
+        QJsonObject params;
+        params["id"] = idToCancel;
+
+        QJsonObject request;
+        request["jsonrpc"] = "2.0";
+        request["id"] = "cancel-1";
+        request["method"] = "$/cancelRequest";
+        request["params"] = params;
+
+        return request;
+    }
+
+    Settings::GeneralSettings m_generalSettings;
+    Settings::CodeCompletionSettings m_completeSettings;
+    MockProviderRegistry m_providerRegistry;
+    MockPromptProvider m_promptProvider;
+    MockDocumentReader m_documentReader;
+    EmptyRequestPerformanceLogger m_performanceLogger;
+    std::unique_ptr<LLMClientInterface> m_client;
+    std::unique_ptr<LLMCore::MockRequestHandler> m_requestHandler;
+    std::unique_ptr<MockProvider> m_provider;
+    std::unique_ptr<LLMCore::PromptTemplate> m_fimTemplate;
+    std::unique_ptr<LLMCore::PromptTemplate> m_chatTemplate;
+};
+
+TEST_F(LLMClientInterfaceTest, initialize)
+{
+    QSignalSpy spy(m_client.get(), &LanguageClient::BaseClientInterface::messageReceived);
+
+    QJsonObject request = createInitializeRequest();
+    m_client->sendData(QJsonDocument(request).toJson());
+
+    ASSERT_EQ(spy.count(), 1);
+    auto message = spy.takeFirst().at(0).value<LanguageServerProtocol::JsonRpcMessage>();
+    QJsonObject response = message.toJsonObject();
+
+    EXPECT_EQ(response["id"].toString(), "init-1");
+    EXPECT_TRUE(response.contains("result"));
+    EXPECT_TRUE(response["result"].toObject().contains("capabilities"));
+    EXPECT_TRUE(response["result"].toObject().contains("serverInfo"));
+}
+
+TEST_F(LLMClientInterfaceTest, completionFim)
+{
+    // Set up the mock request handler to return a specific completion
+    m_requestHandler->setFakeCompletion("test completion");
+
+    m_documentReader.setDocumentInfo(
+        R"(
+def main():
+    print("Hello, World!")
+
+if __name__ == "__main__":
+    main()
+)",
+        "/path/to/file.py",
+        "text/python");
+
+    QSignalSpy spy(m_client.get(), &LanguageClient::BaseClientInterface::messageReceived);
+
+    QJsonObject request = createCompletionRequest();
+    m_client->sendData(QJsonDocument(request).toJson());
+
+    ASSERT_EQ(m_requestHandler->receivedRequests().size(), 1);
+
+    QJsonObject requestJson = m_requestHandler->receivedRequests().at(0).providerRequest;
+    ASSERT_EQ(requestJson["system"].toString(), R"(system prompt
+ Language:  (MIME: text/python) filepath: /path/to/file.py(py)
+
+Recent Project Changes Context:
+ )");
+
+    ASSERT_EQ(requestJson["prompt"].toString(), R"(<SUF>rint("Hello, World!")
+
+if __name__ == "__main__":
+    main()
+<PRE>
+def main():
+    p<MID>)");
+
+    ASSERT_EQ(spy.count(), 1);
+    auto message = spy.takeFirst().at(0).value<LanguageServerProtocol::JsonRpcMessage>();
+    QJsonObject response = message.toJsonObject();
+
+    EXPECT_EQ(response["id"].toString(), "completion-1");
+    EXPECT_TRUE(response.contains("result"));
+
+    QJsonObject result = response["result"].toObject();
+    EXPECT_TRUE(result.contains("completions"));
+    EXPECT_FALSE(result["isIncomplete"].toBool());
+
+    QJsonArray completions = result["completions"].toArray();
+    ASSERT_EQ(completions.size(), 1);
+    EXPECT_EQ(completions[0].toObject()["text"].toString(), "test completion");
+}
+
+TEST_F(LLMClientInterfaceTest, completionChat)
+{
+    ON_CALL(m_promptProvider, getTemplateByName(_)).WillByDefault(Return(m_chatTemplate.get()));
+
+    m_documentReader.setDocumentInfo(
+        R"(
+def main():
+    print("Hello, World!")
+
+if __name__ == "__main__":
+    main()
+)",
+        "/path/to/file.py",
+        "text/python");
+
+    m_completeSettings.smartProcessInstuctText.setValue(true);
+
+    m_requestHandler->setFakeCompletion(
+        "Here's the code: ```cpp\nint main() {\n    return 0;\n}\n```");
+
+    QSignalSpy spy(m_client.get(), &LanguageClient::BaseClientInterface::messageReceived);
+
+    QJsonObject request = createCompletionRequest();
+    m_client->sendData(QJsonDocument(request).toJson());
+
+    ASSERT_EQ(m_requestHandler->receivedRequests().size(), 1);
+
+    QJsonObject requestJson = m_requestHandler->receivedRequests().at(0).providerRequest;
+    auto messagesJson = requestJson["messages"].toArray();
+    ASSERT_EQ(messagesJson.size(), 1);
+    ASSERT_EQ(messagesJson.at(0).toObject()["content"].toString(), R"(user message template prefix:
+
+def main():
+    p
+suffix:
+rint("Hello, World!")
+
+if __name__ == "__main__":
+    main()
+
+)");
+
+    ASSERT_EQ(spy.count(), 1);
+    auto message = spy.takeFirst().at(0).value<LanguageServerProtocol::JsonRpcMessage>();
+    QJsonObject response = message.toJsonObject();
+
+    QJsonArray completions = response["result"].toObject()["completions"].toArray();
+    ASSERT_EQ(completions.size(), 1);
+
+    QString processedText = completions[0].toObject()["text"].toString();
+    EXPECT_TRUE(processedText.contains("# Here's the code:"));
+    EXPECT_TRUE(processedText.contains("int main()"));
+}
+
+TEST_F(LLMClientInterfaceTest, cancelRequest)
+{
+    QSignalSpy cancelSpy(m_requestHandler.get(), &LLMCore::RequestHandlerBase::requestCancelled);
+
+    QJsonObject cancelRequest = createCancelRequest("completion-1");
+    m_client->sendData(QJsonDocument(cancelRequest).toJson());
+
+    ASSERT_EQ(cancelSpy.count(), 1);
+    EXPECT_EQ(cancelSpy.takeFirst().at(0).toString(), "completion-1");
+}
+
+TEST_F(LLMClientInterfaceTest, ServerDeviceTemplate)
+{
+    EXPECT_EQ(m_client->serverDeviceTemplate().toFSPathString(), "Qode Assist");
+}
+
+} // namespace QodeAssist