-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resilience in Schrödinger equation #276
Resilience in Schrödinger equation #276
Conversation
Codecov ReportBase: 71.46% // Head: 71.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 71.46% 71.16% -0.30%
==========================================
Files 239 242 +3
Lines 20183 20640 +457
==========================================
+ Hits 14424 14689 +265
- Misses 5759 5951 +192
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
That's quite a hit in coverage. How much does running the example cost? |
I guess it doesn't cost too much, but I don't really know what to test here. All I do is setup the problem with certain parameters. |
Just run it and see that it does meaningful things in terms of iteration counts, etc.. You don't want to end up with a setup that crashes because.. reasons. |
Looks like the faulty case is not tested, correct? |
textwidth in plotting script
I still don't know why this flakeheaven complaint does not show up on my local machine. I even tried setting up a new conda environment to no avail. Anyways, the "fix" changes the behaviour of the code. Now the except behaviour is entered if there is This is the line in question, by the way. |
This PR adds some stuff for simulating faults in the Schrödinger equation and a file to generate plots that are supposed to go in some publication at some point.
I didn't want to test the function for running the Schrödinger equation because that doesn't contain much new stuff. I did add a test for the flipping of bits in complex numbers, which is also new in this PR.
Also, I changed the way I generate stats in parallel so I can do this on the cluster to get some statistics for PDEs in reasonable time.
Finally, I removed some stuff from the test to check the order of error estimates. Since they produce a plot that goes on the website, I couldn't remove too much stuff, but I am hoping to cut the time in half.
This PR should not change anything related to other peoples projects.