PLAT-480: Update Python Library to APIv2 #28
Conversation
This PR does a first pass at APIv2 compatibility for the python client library. All resource files and resource spec files are now auto-generated.
phildini
changed the title
patreon/api.py
Outdated
| if not includes: | ||
| includes = campaign.default_relationships \ | ||
| + [campaign.Relationships.pledges] | ||
| def fetch_campaigns(self, includes=None, fields=None): |
There was a problem hiding this comment.
this is a second definition of fetch_campaigns with the same signature, no?
| ) | ||
|
|
||
| def fetch_members(self, campaign_id, page_size, cursor=None, includes=None, fields=None): | ||
| url = url = 'campaigns/{0}/members'.format(campaign_id) | ||
| params = {'page[count]': page_size} | ||
| if cursor: |
There was a problem hiding this comment.
this code assumes cursor will be a datetime object -- is that still the case for paginating through members? https://docs.patreon.com/#get-api-oauth2-v2-campaigns-campaign_id-members implies it is not
There was a problem hiding this comment.
I don't think we changed the cursor logic at all for APIv2, so we should be fine?
| ] | ||
|
|
||
|
|
||
| def test_schema_attributes_are_properly_formatted(attributes): |
There was a problem hiding this comment.
(question for my own edification) what calls these? what is attributes as passed in?
There was a problem hiding this comment.
Thank you for reminding me I need to update the README! But it's described in the README.
We could do much more with this in the future.
This PR does a first pass at APIv2 compatibility for the python client library.
All resource files, resource spec files, api files, and api spec files are now auto-generated.
Ran tests locally from python client repo; all passed.