Set up a simple static server. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a basic first step, it gets Iron running and serves a simple static HTML page from assets/index.html. In the future this will be replaced by more complex architecture using Mount, Router, and Static.
|
What is the policy on code review in PistonDevelopers? |
TyOverby
added a commit
that referenced
this pull request
Oct 29, 2014
Set up a simple static server.
|
@reem If you know what you are doing, then self merging saves time according to analysis PistonDevelopers/piston#674 Therefore we should put more effort into knowing what we are doing instead of code review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a basic first step, it gets Iron running and serves a simple
static HTML page from assets/index.html.
In the future this will be replaced by more complex architecture using
Mount, Router, and Static.