-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for comment visibility #217
Comments
|
I would love privacy to be enforced by cryptography, however federation is based on ActivityPub, which to my knowledge does not support non-clear text transactions. We would need to either use another protocol or to extend AP for that to be possible |
AP support text, encrypted text can be stored as text, but yes, if AP can be extended to handle encryption natively, it's better. |
You can store encrypted text as content, but you will loose mentions (which is how receivers are detected for private messages), or it will end up using nasty tricks to get mentions in plaintext alongside encrypted content. Frankly I don't think Plume is where such protocol improvement should be made first, we don't have a user base big enough to extend AP, this should be made by either Mastodon or Pleroma if we want this to be adopted. There are some long-going discussions about that on Mastodon's issue tracker, mainly mastodon/mastodon#1093, but judging from the priority level it's in, this don't seems to be an issue which will be solved any time soon |
Add some support for comment visibility, fix #217 This add a new column to comment, denoting if they are public or not, and a new table linking private comments to those allowed to read them. There is currently no way to write a private comment from Plume. Git is having a hard time what happened in Comment::from_activity, but most of it is just re-indentation because a new block was needed to please the borrow checker. I've marked with comments where things actually changed. At this point only mentioned users can see private comments, even when posted as "follower only" or equivalent. What should we do when someone isn't allowed to see a comment? Hide the whole thread, or just the comment? If hiding just the comment, should we mark there is a comment one can't see, but answers they can, or put other comments like if they answered to the same comment the hidden one do?
Currently any comment Plume receive is shown on the bottom of the concerned post. Visibility for blog post may be assumed to be public, however comments from other software of the fediverse should probably have their visibility respected
The text was updated successfully, but these errors were encountered: