Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for comment visibility #217

Closed
trinity-1686a opened this issue Sep 12, 2018 · 4 comments · Fixed by #364
Closed

Support for comment visibility #217

trinity-1686a opened this issue Sep 12, 2018 · 4 comments · Fixed by #364
Labels
A: Backend Code running on the server A: Federation Stuff related to Federation C: Enhancement New feature or request
Milestone

Comments

@trinity-1686a
Copy link
Contributor

Currently any comment Plume receive is shown on the bottom of the concerned post. Visibility for blog post may be assumed to be public, however comments from other software of the fediverse should probably have their visibility respected

@trinity-1686a trinity-1686a added C: Enhancement New feature or request A: Federation Stuff related to Federation labels Sep 12, 2018
@trinity-1686a trinity-1686a added the S: Duplicate This issue or pull request already exists label Sep 12, 2018
@elegaanz elegaanz reopened this Sep 12, 2018
@elegaanz elegaanz added P: High A: Backend Code running on the server and removed S: Duplicate This issue or pull request already exists labels Sep 12, 2018
@elegaanz elegaanz added this to the 1.0+ milestone Sep 29, 2018
@1000i100
Copy link

Visibility for blog post may be assumed to be public
As default, perhaps, but as the only option, in my opinion, no.
I would like to be able to comment as a DM (direct message), to the article author, or to the author of a public comment, or with a groupe visibility. And i love if the privacy policy is powered by asymetric encryption to ensure it will be respected.

@trinity-1686a
Copy link
Contributor Author

I would love privacy to be enforced by cryptography, however federation is based on ActivityPub, which to my knowledge does not support non-clear text transactions. We would need to either use another protocol or to extend AP for that to be possible

@1000i100
Copy link

AP support text, encrypted text can be stored as text, but yes, if AP can be extended to handle encryption natively, it's better.

@trinity-1686a
Copy link
Contributor Author

You can store encrypted text as content, but you will loose mentions (which is how receivers are detected for private messages), or it will end up using nasty tricks to get mentions in plaintext alongside encrypted content. Frankly I don't think Plume is where such protocol improvement should be made first, we don't have a user base big enough to extend AP, this should be made by either Mastodon or Pleroma if we want this to be adopted. There are some long-going discussions about that on Mastodon's issue tracker, mainly mastodon/mastodon#1093, but judging from the priority level it's in, this don't seems to be an issue which will be solved any time soon

elegaanz pushed a commit that referenced this issue Dec 24, 2018
Add some support for comment visibility, fix #217 

This add a new column to comment, denoting if they are public or not, and a new table linking private comments to those allowed to read them. There is currently no way to write a private comment from Plume.
Git is having a hard time what happened in Comment::from_activity, but most of it is just re-indentation because a new block was needed to please the borrow checker. I've marked with comments where things actually changed.
At this point only mentioned users can see private comments, even when posted as "follower only" or equivalent.

What should we do when someone isn't allowed to see a comment? Hide the whole thread, or just the comment? If hiding just the comment, should we mark there is a comment one can't see, but answers they can, or put other comments like if they answered to the same comment the hidden one do?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Backend Code running on the server A: Federation Stuff related to Federation C: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants