Slightly improve the media experience #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a grid to display the list of media - Add icons for non-image media preview - Paginate the gallery - Add links to the gallery in the editor and in the profile settings to make it more discoverable when you need it Fixes #432
elegaanz
added
C: Enhancement
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=========================================
+ Coverage 25.73% 26.74% +1%
=========================================
Files 63 64 +1
Lines 6150 7223 +1073
=========================================
+ Hits 1583 1932 +349
- Misses 4567 5291 +724 |
Otherwise we can't display their preview, nor show them in articles Also show controls by default for these two elements
trinity-1686a
previously approved these changes
Mar 6, 2019
…sn't need to be escaped. And use it to generate media previews.
elegaanz
added a commit
that referenced
this pull request
Mar 6, 2019
Only keep it if contains letters and numbers only, otherwise remove it. To be merged before #452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some screenshots:
Fixes #432