Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default license #659

Merged
merged 1 commit into from
Aug 27, 2019
Merged

update default license #659

merged 1 commit into from
Aug 27, 2019

Conversation

trinity-1686a
Copy link
Contributor

fix #595

@trinity-1686a trinity-1686a added C: Bug Something isn't working S: Ready for review This PR is ready to be reviewed A: Backend Code running on the server labels Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #659 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   35.11%   35.12%   +<.01%     
==========================================
  Files          68       68              
  Lines        7943     7947       +4     
  Branches     1889     1890       +1     
==========================================
+ Hits         2789     2791       +2     
- Misses       4374     4375       +1     
- Partials      780      781       +1

1 similar comment
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #659 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   35.11%   35.12%   +<.01%     
==========================================
  Files          68       68              
  Lines        7943     7947       +4     
  Branches     1889     1890       +1     
==========================================
+ Hits         2789     2791       +2     
- Misses       4374     4375       +1     
- Partials      780      781       +1

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elegaanz elegaanz merged commit 83cad55 into master Aug 27, 2019
@elegaanz elegaanz deleted the bugfix/595 branch August 27, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Backend Code running on the server C: Bug Something isn't working S: Ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update Default article license
2 participants