Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to the mobile interface #663

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Small improvements to the mobile interface #663

merged 2 commits into from
Aug 19, 2020

Conversation

elegaanz
Copy link
Member

@elegaanz elegaanz commented Sep 1, 2019

cc @marek-lach tell me if this works for you.

@elegaanz elegaanz added A: Front-End Related to the front-end S: Ready for review This PR is ready to be reviewed Rendering How elements're rendered out for the end user Mobile Issues affecting only mobile UX labels Sep 1, 2019
@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #663 into main will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   39.02%   38.98%   -0.04%     
==========================================
  Files          73       73              
  Lines        9777     9777              
  Branches     2240     2240              
==========================================
- Hits         3815     3812       -3     
  Misses       4906     4906              
- Partials     1056     1059       +3     

@elegaanz
Copy link
Member Author

elegaanz commented Sep 1, 2019

I deployed this branch to https://baptiste.gelez.xyz because for some reason Plume CI failed…

@Aldarone
Copy link

Would be nice if a touch on the burger menu button closed it back when it's open.

@igalic
Copy link
Contributor

igalic commented Sep 11, 2019

Would be nice if a touch on the burger menu button closed it back when it's open.

i did say that when @AnaGelez was designing this the first time around…

It seems to fix the overflowing menu items on small screens too
@elegaanz elegaanz merged commit 3881927 into main Aug 19, 2020
@igalic igalic deleted the mobile-margins branch August 19, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Front-End Related to the front-end Mobile Issues affecting only mobile UX Rendering How elements're rendered out for the end user S: Ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Margins are too narrow on mobile Content area and menu overflow past their border on mobile in the new theme
3 participants