Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/delivery address #121

Merged
merged 2 commits into from
Mar 9, 2025
Merged

Fix/delivery address #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
454f5c3
Refactor: Centralize external links in POPOLinks component
khkim6040 Mar 7, 2025
5d67ec6
Delete: Unused Inpostack link from POPOLinks and navbar
khkim6040 Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions components/common/popo-links.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const StudentCouncilArchiveLink =
'https://drive.google.com/drive/u/0/folders/1vHexwLSdD92maoKNlvw9zQ0q0J59k5FD';
const PostechDeliveryLink = 'https://www.postechdorm.com/delivery';

export const POPOLinks = {
StudentCouncilArchiveLink,
PostechDeliveryLink,
};
19 changes: 5 additions & 14 deletions components/navbar/navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ import styled from 'styled-components';
import { Dropdown, Icon, Image, Menu } from 'semantic-ui-react';
import Link from 'next/link';
import MenuItemUser from './menu.item.user';

const StudentCouncilArchiveLink =
'https://drive.google.com/drive/u/0/folders/1vHexwLSdD92maoKNlvw9zQ0q0J59k5FD';
const InpostackLink = 'http://inpostack.poapper.club/';
const PostechDeliveryLink = 'http://delivery.postech.ac.kr/';
import { POPOLinks } from '@/components/common/popo-links';

const Navbar = () => {
return (
Expand Down Expand Up @@ -116,7 +112,7 @@ const MobileNav = () => {
</LinkWithStyle>
</Dropdown.Item>
<Dropdown.Item>
<a href={StudentCouncilArchiveLink} target="_blank">
<a href={POPOLinks.StudentCouncilArchiveLink} target="_blank">
총학생회 기록물관리기관 <Icon name="external" />
</a>
</Dropdown.Item>
Expand All @@ -138,13 +134,8 @@ const MobileNav = () => {
생활백서
</LinkWithStyle>
</Dropdown.Item>
<Dropdown.Item disabled>
<a href={InpostackLink} target={'_blank'}>
인포스택 <Icon name="external" />
</a>
</Dropdown.Item>
<Dropdown.Item>
<a href={PostechDeliveryLink} target={'_blank'}>
<a href={POPOLinks.PostechDeliveryLink} target={'_blank'}>
배달업체 <Icon name="external" />
</a>
</Dropdown.Item>
Expand Down Expand Up @@ -211,7 +202,7 @@ const DesktopNav = () => {
<Dropdown.Item
text={'총학생회 기록물관리기관'}
target="_blank"
href={StudentCouncilArchiveLink}
href={POPOLinks.StudentCouncilArchiveLink}
/>
</Dropdown.Menu>
</Dropdown>
Expand All @@ -235,7 +226,7 @@ const DesktopNav = () => {
</Dropdown.Item>
<Dropdown.Item
text={'배달업체'}
href={'http://delivery.postech.ac.kr/'}
href={POPOLinks.PostechDeliveryLink}
target={'_blank'}
/>
</Dropdown.Menu>
Expand Down
21 changes: 21 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react';
import Link from 'next/link';
import styled from 'styled-components';
import Layout from '@/components/layout';
import { POPOLinks } from '@/components/common/popo-links';

const HomePage: React.FunctionComponent = () => {
return (
Expand Down Expand Up @@ -54,14 +55,14 @@ const circles = [
{ text: '제휴업체', href: '/benefits', icon: '/home/benefits.png' },
{
text: '기록물관리',
href: 'https://drive.google.com/drive/u/0/folders/1vHexwLSdD92maoKNlvw9zQ0q0J59k5FD',
href: POPOLinks.StudentCouncilArchiveLink,
icon: '/home/record.png',
},
{ text: '동아리소개', href: '/club', icon: '/home/club.png' },
{ text: '생활백서', href: '/whitebook', icon: '/home/whitebook.png' },
{
text: '배달업체',
href: 'https://www.postechdorm.com/delivery',
href: POPOLinks.PostechDeliveryLink,
icon: '/home/delivery.png',
},
];
Expand Down