Redesign base url handling #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `clone` command now inserts a placeholder in place of the base url of the source service. It no longer replaces the base url for the user. - The server command no longer guesses the base url to insert; it gets that as a flag from the user. It no longer clobbers external urls (like for sprites). - Added a new command, `transform`, that converts the content in `data/api` to any base url of the user's choice. This replaces the `--location` flag from the old `clone`. - Added an environment variable to set base url to the Dockerfile Overall, this will allow us to generate a copy with any base url without having to reclone every time.
![stickler-ci[bot]](https://avatars.githubusercontent.com/in/15299?s=60&v=4){kind=small}
| @@ -0,0 +1,26 @@ | |||
| from pathlib import Path | |||
| from typing import List | |||
There was a problem hiding this comment.
F401 'typing.List' imported but unused
There was a problem hiding this comment.
Okay I'm disabling stickler merge blocking for now, the usage is right there on line 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clonecommand now inserts a placeholder in place of the base url of the source service. It no longer replaces the base url for the user.transform, that converts the content indata/apito any base url of the user's choice. This replaces the--locationflag from the oldclone.Overall, this will allow us to generate a copy with any base url without having to reclone every time.
Resolves #13