Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added debug trace with DSC version #250

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

anmenaga
Copy link
Contributor

@anmenaga anmenaga commented Nov 1, 2023

PR Summary

2 updates with this PR:

  1. Changed Clap::Args::version (used in dsc -V) to use value from dsc\Cargo.toml. This makes one less place to update when dsc version is incremented after a release.
  2. Added debug statement with the current dsc version; e.g.:
PS C:\DSCv3> dsc -l trace resource get -r Microsoft/OSInfo
  2023-11-01T22:59:24.235180Z DEBUG dsc: Running dsc 3.0.0-alpha.4
    at src\main.rs:48

@anmenaga anmenaga requested a review from SteveL-MSFT November 1, 2023 23:06
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For debug it may make sense to include basic OS info: windows, linux, mac version and architecture, but that can be a different PR. This way when people open bugs, we can just have them copy the output to the issue.

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Nov 2, 2023
Merged via the queue into PowerShell:main with commit 8ba2f6a Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants