Fix input schema validation for RebootPending resource #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anmenaga I think the schema should also reflect the output so people can view the schema and know what to expect even if it takes no input |
SteveL-MSFT
requested changes
Jul 12, 2024
@SteveL-MSFT |
SteveL-MSFT
requested changes
Jul 13, 2024
Co-authored-by: Mikey Lombardi (He/Him) <[email protected]>
SteveL-MSFT
requested changes
Jul 19, 2024
SteveL-MSFT
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #485
When used in a configuration
Microsoft.Windows/RebootPendingwas failing input schema validation.This PR adds empty schema (because
RebootPendingresource expects no input) to resolve that issue.@michaeltlombardi please let me know if this is not the right way to do this for resources that do not take input.