Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wildcard for MAR repository for FindAll and FindByName #1786

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Jan 28, 2025

PR Summary

This pull request to src/code/ContainerRegistryServerAPICalls.cs includes changes to enhance the functionality of finding packages in a container registry and improve the test coverage for the MAR repository. The most important changes include adding a new URL template for listing repositories, modifying the FindAll and FindNameGlobbing methods to use the new FindPackages helper method, and adding new tests for wildcard searches.

Enhancements to finding packages:

  • Added a new URL template containerRegistryRepositoryListTemplate for listing repositories.
  • Modified the FindAll method to use the new FindPackages helper method instead of returning an error.
  • Modified the FindNameGlobbing method to use the new FindPackages helper method instead of returning an error.
  • Added a new helper method FindAllRepositories to list all repositories in the container registry.
  • Added a new helper method FindPackages to find packages using wildcards and handle MAR-specific logic.

Improvements to test coverage:

  • Added new tests to verify finding resources with wildcards in their names and finding all resources in the MAR repository.

PR Context

PR Checklist

Copy link
Member

@anamnavi anamnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback, but overall looks good!

@adityapatwardhan adityapatwardhan merged commit 9aa8538 into PowerShell:master Feb 19, 2025
4 checks passed
@adityapatwardhan adityapatwardhan deleted the WildCardACR branch February 19, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants