-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the hook listener for the hook actionProductAttributeDelete & Removed hooks actionProductOutOfStock & registerGDPRConsent as hook listeners are not defined #106
Conversation
342052e
to
d954429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Progi1984
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Progi1984 ,
Thanks for the PR !
Hooks actionProductOutOfStock
& registerGDPRConsent
are well removed ✅
Regarding the hook actionProductAttributeDelete
, I don't have the same result as what you mentioned in the How to test section.
Here are the steps I followed :
- In a combination product, add a combination A with 0 stock
- Go to product page, add your email address in the email alert section
- See a new line in table ps_mailalert_customer_oos
- Go to product sheet and delete the combination A
- Refresh your database page, line is still present in ps_mailalert_customer_oos
Could you confirm this is the wanted behavior or not ?
Thanks!
@florine2623 This hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Progi1984,
Thanks for the details.
Indeed, now when I delete my whole product and not just an attribute of a product, the line is deleted in the database ✅ the name of the hook is a little confusing ^^
Before I delete my product :
After I delete my product :
Thanks it is QA ✅
Thanks @florine2623 |
Removed hooks actionProductOutOfStock & registerGDPRConsent as hook listeners are not defined
ps_emailalerts
is not linked to hooksactionProductOutOfStock
®isterGDPRConsent
In upgrade, hooks
actionProductOutOfStock
®isterGDPRConsent
are unlinked.When the hook
actionProductAttributeDelete
is triggered, the line is now correctly removed in the tablemailalert_customer_oos