handle missed cases for files in exports maps and transient dependency imports #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
changed the title
thescientist13
commented
Sep 10, 2021
.mocharc.js
Outdated
| @@ -2,5 +2,5 @@ const path = require('path'); | |||
|
|
|||
| module.exports = { | |||
| spec: path.join(__dirname, 'packages/**/test/**/**/**/*.spec.js'), | |||
| timeout: 30000 | |||
| timeout: 90000 | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| version "2.4.0" | ||
| resolved "https://registry.yarnpkg.com/lit-element/-/lit-element-2.4.0.tgz#b22607a037a8fc08f5a80736dddf7f3f5d401452" | ||
| integrity sha512-pBGLglxyhq/Prk2H91nA0KByq/hx/wssJBQFiYqXhGDvEnY31PRGYf1RglVzyLeRysu0IHm2K0P196uLLWmwFg== | ||
| dependencies: | ||
| lit-html "^1.1.1" | ||
|
|
||
| lit-html@^1.1.1: | ||
| lit-html@^1.0.0, lit-html@^1.1.1, lit-html@^1.3.0: |
There was a problem hiding this comment.
Had to manually patch this since I wanted to keep everything at the 1.3.0 version so as not to disrupt other tests by having to versions of lit-html floating around, even though in theory all dependencies could resolve up to 1.4.1 (current).
For posterity, here is what the original entry looked like before
lit-html@^1.0.0, lit-html@^1.3.0:
version "1.4.1"
resolved "https://registry.yarnpkg.com/lit-html/-/lit-html-1.4.1.tgz#0c6f3ee4ad4eb610a49831787f0478ad8e9ae5e0"
integrity sha512-B9btcSgPYb1q4oSOb/PrOT6Z/H+r6xuNzfH4lFli/AWhYwdtrgQkQWBbIc6mdnf6E2IL3gDXdkkqNktpU0OZQA==
lit-html@^1.1.1:
version "1.3.0"
resolved "https://registry.yarnpkg.com/lit-html/-/lit-html-1.3.0.tgz#c80f3cc5793a6dea6c07172be90a70ab20e56034"
integrity sha512-0Q1bwmaFH9O14vycPHw8C/IeHMk/uSDldVLIefu/kfbTBGIc44KGH6A8p1bDfxUfHdc8q6Ct7kQklWoHgr4t1Q==And the results of yarn why
% yarn why lit-html
yarn why v1.22.5
[1/4] 🤔 Why do we have the module "lit-html"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "lit-html"
info Reasons this module exists
- "workspace-aggregator-4ec7cefd-ead9-47f1-8f99-4c6e0447952a" depends on it
- Hoisted from "_project_#@greenwood#cli#@lion#button#@lion#core#lit-html"
- Hoisted from "_project_#@greenwood#cli#@lion#button#@lion#core#@open-wc#scoped-elements#lit-html"
info Disk size without dependencies: "1.31MB"
info Disk size with unique dependencies: "1.31MB"
info Disk size with transitive dependencies: "1.31MB"
info Number of shared dependencies: 0
=> Found "lit-element#[email protected]"
info This module exists because "_project_#@greenwood#cli#lit-element" depends on it.Yarn resolutions could also be an option too if this ends up being problematic.
| }, | ||
| ExportAllDeclaration(node) { | ||
| const sourceValue = node && node.source ? node.source.value : ''; | ||
|
|
||
| if (sourceValue !== '' && sourceValue.indexOf('.') !== 0 && sourceValue.indexOf('http') !== 0) { | ||
| updateImportMap(sourceValue, `/node_modules/${sourceValue}`); | ||
| } | ||
|
|
||
| if (sourceValue.indexOf('.') === 0 && fs.existsSync(path.join(process.cwd(), 'node_modules', dependency, sourceValue))) { | ||
| const moduleContents = fs.readFileSync(path.join(process.cwd(), 'node_modules', dependency, sourceValue)); |
There was a problem hiding this comment.
In the context of #557 , it seems I did indeed overlook other usages of hardcoded node_modules usages like here, which kind of voids the safety intended by landing #674 . 🤦
In a trivial example like on our home page, npx should work, but if a package.json is introduced, the logic here could have potential to break / behave unexpectedly so just wanted to call this out and maybe reopen #557 ?
5 tasks
thescientist13
deleted the
bug/issue-715-flat-exports-map-and-transient-imports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #715
Summary of Changes
TODO
lit@2#611 workv0.16.0-alpha.0release, then I will undraft here