external data sources for pages #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
CLI
discussion
thescientist13
force-pushed
the
feature/issue-21-external-data-sources
branch
from
0b1e1b5 to
1693539
Compare
thescientist13
commented
Dec 23, 2021
| provider: () => { | ||
| return async function () { | ||
| // this could just as easily come from an API, DB, Headless CMS, etc | ||
| const artists = await fetch('http://www.myapi.com/...').then(resp => resp.json()); |
There was a problem hiding this comment.
Not sure if this a good example, or maybe it would be best to keep it simple and just use a blog as the reference?
thescientist13
force-pushed
the
feature/issue-21-external-data-sources
branch
from
5e7b824 to
53ff0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #21
You can test it out like so, using the
namefrom the Artists API responseSummary of Changes
TODOs
buildcommand +mpaoptimization breaks (likely because now not all content is on disk)prerendering page... /artists/jay-st/ prerendering page... /artists/various-artists/ prerendering page... /artists/metal-wings/ prerendering page... /artists/fave/ prerendering complete for page /artists/various-artists/. (node:47671) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received null at validateString (internal/validators.js:124:11) at Object.extname (path.js:1318:5) at file:///Users/owenbuckley/Workspace/project-evergreen/repos/greenwood/packages/cli/src/plugins/resource/plugin-optimization-mpa.js:52:35 at Array.map () at file:///Users/owenbuckley/Workspace/project-evergreen/repos/greenwood/packages/cli/src/plugins/resource/plugin-optimization-mpa.js:51:12 at new Promise () at OptimizationMPAResource.optimize (file:///Users/owenbuckley/Workspace/project-evergreen/repos/greenwood/packages/cli/src/plugins/resource/plugin-optimization-mpa.js:41:12) at file:///Users/owenbuckley/Workspace/project-evergreen/repos/greenwood/packages/cli/src/lifecycles/prerender.js:19:18 at runMicrotasks () at processTicksAndRejections (internal/process/task_queues.js:95:5)buildcommand +ssgmode renders incorrectly for home page, and artists pages don't exist?