fix: ensure proper application reload on configuration change and reg… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ister Prometheus metrics once
armineyvazi
requested review from
Iajrdev and
alipourhabibi
and removed request for
Iajrdev
main.go
Outdated
| os.Exit(1) | ||
| } | ||
| }() | ||
|
|
||
| return server, nil | ||
| } | ||
|
|
||
| func configChanged(oldConfig *config.Config) bool { |
There was a problem hiding this comment.
I think the idea for detecting the reload was that we only reload the services that their config was changed,
For example if only our log configs are changed we should not reload the echo server.
What do you think? @Iajrdev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application Reload on Configuration Change:
The application now properly reloads when a configuration change is detected. This fix improves the signal handling logic, ensuring that the application correctly reinitializes its environment when it receives a SIGHUP signal.
Prometheus Metrics Registration:
Introduced the
sync.Oncepattern to handle the registration of Prometheus metrics within the middleware. This ensures that the metrics are registered only once during the application's lifecycle, preventing any potential duplication or conflicts.