make hamilton heater shaker async #425
Open
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+55
to
+63
| async def _send_command(self, command: str, **kwargs): | ||
| assert len(command) == 2, "Command must be 2 characters long" | ||
|
|
||
| args = "".join([f"{key}{value}" for key, value in kwargs.items()]) | ||
| await asyncio.to_thread(self.io.write, f"T{self.shaker_index}{command}id{str(self.command_id).zfill(4)}{args}".encode()) | ||
|
|
||
| self.command_id = (self.command_id + 1) % 10_000 | ||
| response = await asyncio.to_thread(self.io.read) | ||
| return response |
There was a problem hiding this comment.
actually i don't think the read or write themselves take so long and introducing multithreading leads to potential complications
i think it's better to do many small reads and asyncio.sleep in between
There was a problem hiding this comment.
i think it's better to do many small reads and asyncio.sleep in between
Shouldn't the read be awaitable? Such that a await self.io.read() should be sufficient? Otherwise each backend using the io layer needs to implement this logic again?
There was a problem hiding this comment.
Better idea, will go with that
|
just found out this also breaks .decode on get_temperature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with 8x hhs box