fix: upgrade the toolchain #325
Conversation
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
|
Not sure about the i686-unknown-linux-gnu CI failure. It also failed in the main branch. |
dist/index.js
Outdated
| @@ -12114,6 +12114,7 @@ async function hostBuild(maturinRelease, args) { | |||
| const sccache = core.getBooleanInput('sccache'); | |||
| const isUniversal2 = args.includes('--universal2') || target === 'universal2-apple-darwin'; | |||
| core.startGroup('Install Rust target'); | |||
| await exec.exec('rustup', ['update']); | |||
There was a problem hiding this comment.
I don't quite like doing this unconditionally, I think we only need to do this when Rust toolchain is not specified or set to stable/beta/nightly while the currently installed version < MSRV specified in Cargo.toml.
There was a problem hiding this comment.
That might break many repos upgrading to edition2024 with the default GitHub action settings. We might also need to update the README.
How about moving it to the next if (rustToolchain) block? So it will always update the toolchain if specified. My concern is that MSRV is not a compulsory configuration while it's common to use the latest stable version in dev.
There was a problem hiding this comment.
How about moving it to the next
if (rustToolchain)block?
Sounds better and it should also pass the rust toolchain argument.
I've disabled the test, please rebase onto main to fix CI. |
Rebased. Shall we add some notes to the README that upgrading to |
Signed-off-by: Keming <[email protected]>
|
CI failed due to the docker pull limit. But the previous one succeeded. No code change in the latest commit. |
rustup updatein the container to get the latest stable version #324