Make datetime rust wrappers compatible with abi3 feature
#4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
force-pushed
the
abi3-datetime
branch
5 times, most recently
from
5dc6f51 to
8903887
Compare
bschoenmaeckers
force-pushed
the
abi3-datetime
branch
from
61df79e to
9818977
Compare
bschoenmaeckers
force-pushed
the
abi3-datetime
branch
from
9818977 to
27419dc
Compare
bschoenmaeckers
force-pushed
the
abi3-datetime
branch
from
27419dc to
a5615a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
PyDate,PyTime,PyDateTime,PyDelta, andPyTzInfoavailable inabi3builds. However,PyDateAccess,PyTimeAccess, andPyDeltaAccesshave not been enabled, as they can fail underabi3, and their return values are not PyResult, making error handling problematic.For now, fields in these wrappers should still be accessed using getattr, though we may consider changing this in the future.