Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datetime rust wrappers compatible with abi3 feature #4970

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bschoenmaeckers
Copy link
Member

@bschoenmaeckers bschoenmaeckers commented Mar 11, 2025

This PR makes PyDate, PyTime, PyDateTime, PyDelta, and PyTzInfo available in abi3 builds. However, PyDateAccess, PyTimeAccess, and PyDeltaAccess have not been enabled, as they can fail under abi3, and their return values are not PyResult, making error handling problematic.

For now, fields in these wrappers should still be accessed using getattr, though we may consider changing this in the future.

@bschoenmaeckers bschoenmaeckers force-pushed the abi3-datetime branch 5 times, most recently from 5dc6f51 to 8903887 Compare March 12, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant