fix native types not implementing is_type_of correctly
#4981
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4981 will improve performances by 11.99%Comparing Summary
Benchmarks breakdown
|
davidhewitt
commented
Mar 14, 2025
| @@ -152,7 +152,7 @@ macro_rules! pyobject_native_type_info( | |||
|
|
|||
| $( | |||
| #[inline] | |||
| fn is_type_of_bound(obj: &$crate::Bound<'_, $crate::PyAny>) -> bool { | |||
| fn is_type_of(obj: &$crate::Bound<'_, $crate::PyAny>) -> bool { | |||
There was a problem hiding this comment.
The point here being that is_type_of_bound is defaulted to just call is_type_of. is_type_of has a generic default which calls PyObject_TypeCheck instead of more specific (faster) functions like PyList_Check.
|
Performance improvement is likely real due to fixing use of specialised functions. Nice free win 🎉 |
Icxolu
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while having a look at removing all the
_boundmethods from the code (as a first step towards 0.25).This seems like a bugfix worth landing on the 0.24 series, so I split it out.