add PyInt constructor for all supported number types (i32, u32, i64, u64, isize, usize, f64) #4984
+86
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a part of #2221.
I deliberately did not implement support for
PyLong_FromString
because I don't feel familiar enough with the codebase to do this in my first PR.I am aware that my
ToPyInt
trait will not work withPyLong_FromString
, becausePyLong_FromString
takes more parameters than just a single value. I acknowledge that changing the trait to also accommodatePyLong_FromString
will be a breaking change, but one could also add a dedicated constructor for that instead of squeezing it intonew
.