-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create External Table without schema [Spark] #168
Conversation
We need to test this solution on the EMR clusters with Glue Catalog, see if we miss something else in the implementation and if everything works correctly. |
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 81 81
Lines 1925 1941 +16
Branches 145 154 +9
=======================================
+ Hits 1804 1819 +15
- Misses 121 122 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hello @Adricu8 !! Do you think this is ready to merge? Did you find any bug creating external tables with Qbeast? (We still missing pre-load the |
Hi Paola! I did not find any issue with this. Creating external tables worked fine for me :) |
Perfect! Could you approve the PR? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, thanks Paola :)
Description
This PR fixes #165
Type of change
When creating an external table with an already populated directory, Qbeast was missing the schema in the final Catalog entry.
We add a method to detect this specific situation and update the service accordingly.
Checklist:
Here is the list of things you should do before submitting this pull request:
How Has This Been Tested? (Optional)
A new test is added in
QbeastCatalogIntegrationTest
in which we try to create an external table without schema.