Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Force esbuild package version to 0.12 #79

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented May 18, 2022

Changes

From modernweb-dev/web#1929 we need to fix the esbuild package version to 0.12. Now dev-server-esbuild since 0.3.0 accepts higher esbuild versions and it seems that there are some compatibility problems.
Co-authored-by: @korgan00

Implementation details

  • Fixed the version of esbuild in the package.json to 0.12.

How to read this PR

  • Just check that in package.json and package-lock.json is being loaded the correct esbuild version

@Tansito Tansito requested a review from korgan00 May 18, 2022 11:15
@Tansito Tansito requested a review from abdonrd as a code owner May 18, 2022 11:15
@changeset-bot
Copy link

changeset-bot bot commented May 18, 2022

⚠️ No Changeset found

Latest commit: 9c4a0bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@korgan00 korgan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, Thank you!

Copy link
Member

@abdonrd abdonrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys!

@abdonrd abdonrd merged commit de0875b into main May 19, 2022
@abdonrd abdonrd deleted the force-esbuild-version branch May 19, 2022 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants