Bugfix/Catch2 update #348
Merged
Bugfix/Catch2 update #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for distributed testing.
In some unit tests, the number of ranks (int) was set to a value exceeding INT_MAX. This commit caps the number of qubits the tests are run with to a number (16 or 32) that avoids this.
|
Building tests with distribution and multithreading on, and running them locally with 4 processes on Fritz yields |
|
Does this mean that with distributed and multi threading off it fails? Or did I miss that? |
|
The non-distributed unit tests are run automatically by the the CI, but distributed and GPU need to be tested separately, because github doesn't support them (but we usually only run complete tests with all configurations for merges to the master branch). Since some modifications need to be made to Catch2 to perform the distributed tests properly, I ran them anyway to make sure they work. |
|
Looks great, nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Catch2 to the latest available v2.x (2.13.10) to make the unit tests aware of ARM Macs, fixing #346.
Running unit tests locally on an M1 Mac revealed an integer overflow bug in the tests, which this PR also fixes, along with some required numerical tolerance increases for some tests.