Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken top_level.txt file in distribution #571

Closed
alexamici opened this issue Jan 9, 2016 · 0 comments · Fixed by #573
Closed

Broken top_level.txt file in distribution #571

alexamici opened this issue Jan 9, 2016 · 0 comments · Fixed by #573
Labels
enhancement New feature or request fix-in-progress meta Relates primarily to the project and not users of the project.
Milestone

Comments

@alexamici
Copy link
Contributor

This is what the setuptools documentation says about the top_level.txtfile:

This file is a list of the top-level module or package names provided by the project, one Python identifier per line.

Subpackages are not included; a project containing both a foo.bar and a foo.baz would include only one line, foo, in its top_level.txt.

The file distributed with rdflib can be accessed with:

>>> import pkg_resources
>>> provider = pkg_resources.get_distribution('rdflib')
>>> print(provider.get_metadata('top_level.txt'))
rdflib
rdflib/extras
rdflib/plugins
rdflib/plugins/parsers
rdflib/plugins/parsers/pyMicrodata
rdflib/plugins/parsers/pyRdfa
rdflib/plugins/parsers/pyRdfa/extras
rdflib/plugins/parsers/pyRdfa/host
rdflib/plugins/parsers/pyRdfa/rdfs
rdflib/plugins/parsers/pyRdfa/transform
rdflib/plugins/serializers
rdflib/plugins/sparql
rdflib/plugins/sparql/results
rdflib/plugins/stores
rdflib/tools

and is clearly broken as it should only contain le first line.

I think the problem is that the packages variable in setup.py is not what should be passed to the packages= keyword argument.

alexamici added a commit to alexamici/rdflib that referenced this issue Jan 9, 2016
alexamici added a commit to alexamici/rdflib that referenced this issue Jan 10, 2016
Minimal change that should fix RDFLib#571. This time for real.
@joernhees joernhees added enhancement New feature or request meta Relates primarily to the project and not users of the project. labels Jan 25, 2016
@joernhees joernhees added this to the rdflib 4.2.2 milestone Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix-in-progress meta Relates primarily to the project and not users of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants