Updating namespace.py to solve issue #801 #1044
Conversation
Added acceptance clause for "%" in Allowed name chars.
Test file to increase the scope of n amespaces.
|
Were you able to check if this also results in valid results for the other serialization formats? #801 (comment) |
|
Yes on making the changes described in my code I was able to get valid results other serialization formats also. |
|
Sir, |
test/test_issue801
Outdated
| Issue 715 - path query chaining issue | ||
| Some incorrect matches were found when using oneOrMore ('+') and | ||
| zeroOrMore ('*') property paths and specifying neither the | ||
| subject or the object. |
There was a problem hiding this comment.
This comment looks out of date.
There was a problem hiding this comment.
@darrengarvey I have updated the comment
test/test_issue801
Outdated
| g.bind('', example) | ||
| node = BNode() | ||
| g.add((node, example['first%20name'], Literal('John'))) | ||
| print(g.serialize(format="turtle").decode()) |
There was a problem hiding this comment.
Shouldn't this be checking the result of the serialisation?
There was a problem hiding this comment.
@darrengarvey I have added the assert statement for checking the result
Deleting test_issue801
Updated test file to test issue 801
Added assertions for testing issue RDFLib#801
test/test_issue801.py
Outdated
| @@ -13,7 +13,8 @@ def test_issue_801(self): | |||
| g.bind('', example) | |||
| node = BNode() | |||
| g.add((node, example['first%20name'], Literal('John'))) | |||
| print(g.serialize(format="turtle").decode()) | |||
| self.assertEqual(g.serialize(format="turtle").decode().split("\n")[-3] == '[] :first%20name "John" .', True) | |||
There was a problem hiding this comment.
Can this instead be:
self.assertEqual(g.serialize(format="turtle").decode().split("\n")[-3],
'[] :first%20name "John" .')
That way if the test fails you get to see what both sides of the equality comparison are. Plus keeping the line length shorter and making the string easier to see.
There was a problem hiding this comment.
@darrengarvey I have applied the requested changes
test/test_issue801.py
Outdated
| @@ -13,7 +13,8 @@ def test_issue_801(self): | |||
| g.bind('', example) | |||
| node = BNode() | |||
| g.add((node, example['first%20name'], Literal('John'))) | |||
| print(g.serialize(format="turtle").decode()) | |||
| self.assertEqual(g.serialize(format="turtle").decode().split("\n")[-3] == '[] :first%20name "John" .', True) | |||
| print (g.serialize(format="turtle").decode()) | |||
There was a problem hiding this comment.
This is going to make test run output noisy. I don't see other tests in rdflib printing output, so do you need this?
There was a problem hiding this comment.
@darrengarvey I have applied the requested changes
Removed print statement Reformatting assert statement
There was a problem hiding this comment.
LGTM.
(@aayush17002 I'm not a developer, but thought I'd review anyway)
|
@aayush17002 please merge in |
|
@nicholascar I have merged into the master branch again as suggested by you |
Added acceptance clause for "%" in Allowed name chars.
Closes #801