Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Graph.transitive_{subjects,objects} #1307

Merged
merged 1 commit into from
May 13, 2021
Merged

Add tests for Graph.transitive_{subjects,objects} #1307

merged 1 commit into from
May 13, 2021

Conversation

aucampia
Copy link
Member

This is based on examples/transitive.py

Related to #1305

Proposed Changes

  • Add tests for Graph.transitive_subjects
  • Add tests for Graph.transitive_objects

@aucampia
Add tests for Graph.transitive_{subjects,objects}
424069f 
This is based on examples/transitive.py
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.444% when pulling 424069f on iafork:transitive_tests into db9ee6a on RDFLib:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.444% when pulling 424069f on iafork:transitive_tests into db9ee6a on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.444% when pulling 424069f on iafork:transitive_tests into db9ee6a on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.444% when pulling 424069f on iafork:transitive_tests into db9ee6a on RDFLib:master.

@aucampia
Copy link
Member Author

@nicholascar here are some tests as mentioned in #1305

If anyone has suggestions for more tests please let me know, maybe we can make an issue/suggestion to add them.

@nicholascar nicholascar self-requested a review May 13, 2021 02:45
nicholascar
nicholascar approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @aucampia !

@nicholascar nicholascar merged commit 8d592a2 into RDFLib:master May 13, 2021
@aucampia aucampia deleted the transitive_tests branch November 17, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholascar nicholascar nicholascar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aucampia @coveralls @nicholascar