Fix formatting of xsd:decimal #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholascar
requested review from
white-gecko and
nicholascar
and removed request for
white-gecko
nicholascar
approved these changes
Jun 11, 2021
xsd:decimal should never be formatted with e-notation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314
Proposed Changes
xsd:decimalusingf"{x:f}"to ensure it complies with https://www.w3.org/TR/xmlschema11-2/#decimalNOTE: This uses the tests added in #1315 so it might make sense to merge that first before this, only the second commit (c018c8f) is relevant here.