Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require setuptools, rdflib/plugins/sparql/__init__.py and rdflib/plugin.py import pkg_resources #1339

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

hrnciar
Copy link
Contributor

@hrnciar hrnciar commented Jun 17, 2021

Proposed Changes

  • list setuptools as a runtime dependency

@aucampia
Copy link
Member

Can you clarify what problem this is supposed to fix?

@hrnciar
Copy link
Contributor Author

hrnciar commented Jun 21, 2021

In Fedora, we package RPM package for rdflib. I am not the maintainer of that package, but the maintainer of Python in Fedora.

We used to automatically generate a runtime dependency on setuptools for all RPM packages with Python projects with console_scripts entrypoints. Reason for this was that it was necessary for the way how was entrypoint script generated. Nowadays the entrypoint script looks differently. Particularly, they do not require setuptools to be installed on runtime in order to execute (at least on Python 3.8+ -- because it has importlib.metadata).

Hence we are about to stop generating the automatic runtime dependency on setuptools for packages with console_scripts entrypoints. We went through all the affected packages in Fedora and identified some packages that will be negatively impacted in Fedora because when we stop adding the requirement automatically, they will have missing dependencies, because they use setuptools (pkg_resources) on runtime, but don't specify a dependency.

As long as you import from pkg_resources in the actual code, the project requires setuptools on runtime and the requirement needs to be specified, otherwise it might be missing.

@nicholascar nicholascar merged commit 152ab8a into RDFLib:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants