-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Py 3.10 to testing envs #1473
Conversation
The problem you are seeing here is because of #1455 It may be best to just switch from isodate to isodate2. I have tried reaching out to @gweis who maintained isodate to get him to hand it over to |
Thanks for the diagnosis @aucampia: I haven't come back to this after just adding in the 3.10 instructions. How do you figure out @gweis was at Griffith Uni?? That's just down the road from where I live and I've even supervised students from that uni! Actually, I think he works for TERN Australia now, same place as @edmondchuc who is a regular rdflib contributor!!! I'll ask Edmond. |
I saw it on Gerhard Weis's linkedin (where I also reached out) but it may not be current anymore, would be good to get hold of him though. |
Here he is: https://www.tern.org.au/team/!! I've tried to contact him just now via his new employment. What a coincidence that he now works for TERN! I've worked with TERN a lot for many years. I'll easily get hold of him, even if I have to go and visit him in person. Can you please email me your email address at [email protected]? |
Sent now, hope it did not end in spam. |
restarting tests |
@aucampia any idea why this is still failing? It seems to always fall over due to the error Also, why do we have CICT on PR and also Push? They seem to be testing for the same things. |
It is failing because there is no JDK/JRE in the image that you use, adding this line before running with-fuseki will fix it: - apt-get update && apt-get install -y openjdk-11-jdk-headless https://drone.rdflib.ashs.dev/RDFLib/rdflib/751/4/2 738 ERROR: pid 89 (fuseki-normal) not running anymore ...
100s
739 declare -- fuseki_pid_normal="89"
100s
740 declare -- fuseki_pid_tdb="90"
100s
741 INFO: killing pid 89 (fuseki-normal)
100s
742 ./with-fuseki.sh: line 54: kill: (89) - No such process
100s
743 INFO: pid 89 (fuseki-normal) is dead
100s
744 INFO: killing pid 90 (fuseki-tdb)
100s
745 INFO: pid 90 (fuseki-tdb) is dead
100s
746 dumping fuseki_log_normal=./var/apache-jena-fuseki-3.17.0/run-normal/out.log
100s
747 Cannot find a Java JDK.
100s
748 Please set either set JAVA or JAVA_HOME and put java (>=1.8) in your PATH.
100s
749 dumping fuseki_log_tdb=./var/apache-jena-fuseki-3.17.0/run-tdb/out.log
100s
750 Cannot find a Java JDK.
100s
751 Please set either set JAVA or JAVA_HOME and put java (>=1.8) in your PATH. I will tune the error message there a bit to indicate the reason for failure can be found in the log lines that follow.
I'm a bit new to github actions still, I will make a PR to tune this a bit, I think the on-block should be changed to this - ideally we want it to run on PRs, and every push to main, on:
push:
branches: ["main"]
pull_request:
branches: ["main"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, I added two suggestions though to fix the build and variable that was renamed.
Co-authored-by: Iwan Aucamp <[email protected]>
Co-authored-by: Iwan Aucamp <[email protected]>
Changes made as requested and tests pass, so I'll merge without a follow-up review! |
Add testing for Python 3.10
Replaces the closed PR #1439
Needed for PR #1450