-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isort #1689
Add isort #1689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, I will anyway update #1672 with your isort config.
pre-commit CI can auto fix this, and this way we can idenpendently evaluate the formatting of the code from the validity of the code.
I changed this branch so it is enforced by pre-commit instead of github actions, that way we have autofix and we can independently evaluate the formatting of PRs and the correctness of PRs. |
Good move, thanks. |
Ref #1687
Proposed Changes