Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isort #1689

Merged
merged 10 commits into from
Feb 20, 2022
Merged

Add isort #1689

merged 10 commits into from
Feb 20, 2022

Conversation

eggplants
Copy link
Contributor

Ref #1687

Proposed Changes

  • add isort configuration
  • format with isort
  • add isort checker to CI

aucampia
aucampia approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@aucampia aucampia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, I will anyway update #1672 with your isort config.

@eggplants eggplants requested a review from aucampia February 10, 2022 07:01
@aucampia
Merge remote-tracking branch 'upstream/master' into eggplants_isort
908abe8
@aucampia
Use pre-commit to check isort
54acf8c 
pre-commit CI can auto fix this, and this way we can idenpendently evaluate
the formatting of the code from the validity of the code.
@aucampia
Copy link
Member

I changed this branch so it is enforced by pre-commit instead of github actions, that way we have autofix and we can independently evaluate the formatting of PRs and the correctness of PRs.

@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Feb 20, 2022
@ashleysommer
Copy link
Contributor

I changed this branch so it is enforced by pre-commit instead of github actions

Good move, thanks.

@ashleysommer ashleysommer merged commit 778bf08 into RDFLib:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucampia aucampia aucampia approved these changes

@nicholascar nicholascar Awaiting requested review from nicholascar

@ashleysommer ashleysommer Awaiting requested review from ashleysommer

@white-gecko white-gecko Awaiting requested review from white-gecko

Assignees
No one assigned
Labels
review wanted This indicates that the PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eggplants @aucampia @ashleysommer