change pytest.skip to pytest.xfail

[ghost]

Fix for issue #1793

Summary of changes

Change pytest.skip to pytest.xfail in test/test_dawg.py and test/test_parsers/test_swap_n3.py

Checklist

• Checked that there aren't other open pull requests for the same change.
• Checked that all tests and type checking passes.
• Considered granting push permissions to the PR branch,
  so maintainers can fix minor issues and keep your PR up to date.

[aucampia]

Looks great @gjhiggins - thank you.

[ghost]

Looks great @gjhiggins - thank you.

No worries, “glad to be of service”

[ghost]

inexplicable gh-actions failures. I have

$ diff -x .venv \
>     -x .git \
>     -x var \
>     -x __pycache__ \
>     -x .pytest_cache \
>     -x rdflib.egg-info \
>     -x runcleantests.sh \
>     -uNr rdflib rdflib-github-fix-for-issue1793-convert-skip-to-xfail
diff -x .venv -x .git -x var -x __pycache__ -x .pytest_cache -x rdflib.egg-info -x runcleantests.sh -uNr rdflib/test/test_dawg.py rdflib-github-fix-for-issue1793-convert-skip-to-xfail/test/test_dawg.py
--- rdflib/test/test_dawg.py	2022-01-06 18:12:23.969808430 +0000
+++ rdflib-github-fix-for-issue1793-convert-skip-to-xfail/test/test_dawg.py	2022-04-09 18:07:43.250240884 +0100
@@ -212,7 +212,7 @@
     query_path: PurePath = file_uri_to_path(query)
 
     if uri in skiptests:
-        pytest.skip()
+        pytest.xfail()
 
     try:
         g = Dataset()
@@ -359,7 +359,7 @@
     resfile_path = file_uri_to_path(resfile) if resfile else None
 
     if uri in skiptests:
-        pytest.skip()
+        pytest.xfail()
 
     def skip(reason="(none)"):
         print("Skipping %s from now on." % uri)
diff -x .venv -x .git -x var -x __pycache__ -x .pytest_cache -x rdflib.egg-info -x runcleantests.sh -uNr rdflib/test/test_parsers/test_swap_n3.py rdflib-github-fix-for-issue1793-convert-skip-to-xfail/test/test_parsers/test_swap_n3.py
--- rdflib/test/test_parsers/test_swap_n3.py	2022-03-23 10:35:51.182684269 +0000
+++ rdflib-github-fix-for-issue1793-convert-skip-to-xfail/test/test_parsers/test_swap_n3.py	2022-04-09 17:02:25.778716787 +0100
@@ -71,7 +71,7 @@
 def generictest(e):
     """Documentation"""
     if e.skip:
-        pytest.skip("%s skipped, known issue" % e.name)
+        pytest.xfail("%s skipped, known issue" % e.name)
     g = rdflib.Graph()
     for i in [rdf, rdfs, xsd, owl, test, n3test, rdft, triage, mf, qt]:
         g.bind(str(i), i)

So I don't know where the errors are coming from ☹️

[aucampia]

So I don't know where the errors are coming from

Will check it later today.

[ghost]

So I don't know where the errors are coming from

Will check it later today.

Much appreciated, thank you.

[aucampia]

It is failing because of this:

• Getting type error "_SpecialForm" not callable for pyparsing 3.0.8 pyparsing/pyparsing#385

[aucampia]

So I don't know where the errors are coming from

Will check it later today.

Much appreciated, thank you.

This alleviates the problem for now:

• Ignore pyparsing type hints #1802

[aucampia]

CI passes now, I will merge tomorrow if there is no further feedback.