-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 1808 #1821
Fix issue 1808 #1821
Conversation
@edmondchuc - pre commit errors can be fixed by making a comment "pre-commit.ci autofix" |
pre-commit.ci autofix |
Thanks for the tip @aucampia and thanks @nicholascar for commenting. I'm hoping this PR fixes both #1808 and #1404 without introducing further side effects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Will review in about an hour, just fixing some other issues. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@edmondchuc I have added some more tests now - and I'm fairly comfortable with the change after adding them - hope they are okay with you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks good, thanks @edmondchuc
Planning to merge on or before 2022-04-17 if there is no further feedback. |
Thanks for adding the additional tests @aucampia. |
Won't merge before #1838 |
Summary of changes
Fixes #1808
Essentially we are reverting back to returning a
URIRef
in theURIRef.skolemize()
method and changing howGraph.de_skolemize()
method converts subjects and objects of a statement to aBNode
.I think this change is much safer than changing what is returned by
URIRef.skolemize()
and potentially affecting other parts of the library. I've had a search through the codebase and nothing else touches theGraph.de_skolemize()
.Checklist
the same change.
./examples
for new features.CHANGELOG.md
).so maintainers can fix minor issues and keep your PR up to date.