-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1429, add iri2uri
#1902
Fixes #1429, add iri2uri
#1902
Conversation
Kudos, SonarCloud Quality Gate passed!
|
- Move `rdflib.parser.iri2uri` to `rdflib.util._iri2uri` In part this is because iri2uri does not operate on all IRIs, just http and https IRIs, but furthermore it is because this is not something essential to working with RDF. - Expanded tests for `iri2uri` to cover each part of the URI. - Convert the test that connects to dbpedia to using httpmock. This is so we have more control over response and can explicitly verify the request path. - Some changes to imports to reduce the probability of circular imports.
Made some changes now to your branch, in brief:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good.
Fixes #1429
#1429 (comment))
Summary of changes
Add an iri-to-uri conversion utility to encode IRIs to URIs for
Graph.parse()
sources. Added a couple of tests because feeding it with a suite of IRIs to check seems overkill (not that I could find one).Checklist
./examples
for new features.CHANGELOG.md
).so maintainers can fix minor issues and keep your PR up to date.