test: fix GraphHelper.quad_set handling of Dataset
#1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GraphHelper.quad_set` was doing the wrong thing for Datasets because Datasets are not exactly a subclass of ConjunctiveGraph. This adds special handling for Dataset so it works correctly. Also: - Fix some flake8 errors
aucampia
force-pushed
the
iwana-20220516T1841-flake8_fixes
branch
from
0ca0f1f to
2b4fe25
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
GraphHelper.quad_setwas doing the wrong thing for Datasets becauseDatasets are not exactly a subclass of ConjunctiveGraph.
This adds special handling for Dataset so it works correctly.
Also:
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.