Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPARQL test data #1981

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Fix SPARQL test data #1981

merged 1 commit into from
Jun 5, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Jun 4, 2022 •
edited
Loading

Summary of changes

This patch syncs the content of test/data/suites/w3c/dawg-data-r2/
and test/data/suites/w3c/sparql11/ with the upstream sources for these
tests so we know that we are running the official test suites.

Other changes:

  • Use .gitattributes to instruct git to not tamper with the content of
    test/data/suites/w3c/.
  • Add an ingore for one more test of SPARQL which fails after this sync.
  • Ignore some extraneous files that come from upstream sources,
    specifically .bak and MacOS files.

NOTE: Diff is significantly more terse when ignoring whitespaces, diff with ignored whitespaces can be found here.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
Fix SPARQL test data
de5f859 
This patch syncs the content of `test/data/suites/w3c/dawg-data-r2/`
and `test/data/suites/w3c/sparql11/` with the upstream sources for these
tests so we know that we are running the offical test suites.

Other changes:
- Use `.gitattributes` to instruct git to not tamper with the content of
  `test/data/suites/w3c/`.
- Add an ingore for one more test of SPARQL which fails after this sync.
- Ignore some extraneous files that come from upstream sources,
  specifically .bak and MacOS files.
@aucampia aucampia marked this pull request as ready for review June 4, 2022 19:10
@aucampia aucampia requested a review from a team June 4, 2022 19:10
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 88.516% when pulling de5f859 on aucampia:iwana-20220604T2057-sparql_test_data into aa33f9a on RDFLib:master.

ghost
ghost approved these changes Jun 5, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to have #1910 closed

@aucampia aucampia linked an issue Jun 5, 2022 that may be closed by this pull request
Fix SPARQL11 test suite data #1910
Closed
@aucampia aucampia merged commit 148e4a2 into RDFLib:master Jun 5, 2022
@aucampia aucampia linked an issue Jun 5, 2022 that may be closed by this pull request
Fix DAWG data-r2 test data #1911
Closed
@aucampia aucampia mentioned this pull request Jun 5, 2022
Closed
@aucampia aucampia linked an issue Jun 5, 2022 that may be closed by this pull request
Instruct Git to not tamper with test data #1848
Closed
@aucampia aucampia mentioned this pull request Jun 5, 2022
Closed
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 8, 2022
@aucampia aucampia deleted the iwana-20220604T2057-sparql_test_data branch June 23, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix DAWG data-r2 test data Fix SPARQL11 test suite data Instruct Git to not tamper with test data
2 participants
@aucampia @coveralls