feat: add type hints for rdflib.store and rdflib.plugins.stores
#2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will publish this tomorrow, I'm writing a script to diff python source code with type hints and comments removed, so it is easier to review these PRs. |
aucampia
force-pushed
the
iwana-20220728T1941-store_typing
branch
2 times, most recently
from
8303d8e to
97c686f
Compare
|
Compact diff can be found here: https://gist.github.com/aucampia/3f380070fbd8f0e8a99aea2df6cc1f06 |
|
@ajnelson-nist @mielvds tagging you in case you have time to review. |
|
@aucampia : I don't really have experience with this area in the code, so I don't have cogent feedback aside from noticing a documentation typo. |
aucampia
force-pushed
the
iwana-20220728T1941-store_typing
branch
from
97c686f to
5d05b96
Compare
Add type hints and aliases for `rdflib.store` and `rdflib.plugins.stores` and also add a couple of more type hints and aliases to `rdflib.graph`. This PR contains no runtime changes. Other changes: - Changed some imports to be more specific (e.g. `import from rdflib.graph` instead of `import from rdflib`). This is to reduce the probability of circular imports. - Ignore `E231` (missing whitespace after ',') in flake8 as black is managing the whitespaces and seems to be bumping heads with flake8 with spaces after `,` sometimes. - Install `berkeleydb-stubs` when doing extensive testing with tox. - Added `devtools/diffrtpy.py` which is a script that can be used with `git difftool` to generate compact diffs for python code. This should make it a lot easier to review PRs that change type hints to verify that they don't have a runtime impact.
aucampia
force-pushed
the
iwana-20220728T1941-store_typing
branch
from
5d05b96 to
16d9618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add type hints and aliases for
rdflib.storeandrdflib.plugins.storesand also add a couple of more type hints andaliases to
rdflib.graph.This PR contains no runtime changes.
Other changes:
import from rdflib.graphinstead ofimport from rdflib). This is to reducethe probability of circular imports.
E231(missing whitespace after ',') in flake8 as black ismanaging the whitespaces and seems to be bumping heads with flake8
with spaces after
,sometimes.berkeleydb-stubswhen doing extensive testing with tox.devtools/diffrtpy.pywhich is a script that can be used withgit difftoolto generate compact diffs for python code. This shouldmake it a lot easier to review PRs that change type hints to verify
that they don't have a runtime impact.
Compact diff: https://gist.github.com/aucampia/3f380070fbd8f0e8a99aea2df6cc1f06
Checklist
the same change.
CHANGELOG.md).so maintainers can fix minor issues and keep your PR up to date.