-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue2179 incorrect headers #2183
Conversation
The headers are not in the top level of the dictionary so a shallow copy will still result in the same dict being used for headers in each HTTP request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @gitmpje, copy was not enough, it needed a deepcopy, but the test was great and you found the exact source of the problem which is very helpful.
I changed copy to deepcopy and also changed the test to run everything twice so that any issues with ordering is picked up both ways.
I will merge by the weekend if there are no further changes. |
@aucampia Thank you for fixing this issue more fundamentally and resolving the formatting issues. Using |
Summary of changes
This PR solves issue 2179 "Wrong Content-Type header was sent with query GET request after a POST update request".
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.