Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eliminate use of deprecated rdflib.path.evalPath #2266

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

aucampia
Copy link
Member

Summary of changes

evalPath is deprecated but still being used by some code in RDFLib. This change replaces usage of rdflib.path.evalPath with rdflib.path.eval_path.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

`evalPath` is deprecated but still being used by some code in RDFLib.
This change replaces usage of `rdflib.path.evalPath` with
`rdflib.path.eval_path`.
@aucampia aucampia changed the title fix: eliminate usage of deprecated rdflib.path.evalPath fix: eliminate use of deprecated rdflib.path.evalPath Mar 12, 2023
@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Mar 12, 2023
@coveralls
Copy link

Coverage Status

Coverage: 90.765% (-0.01%) from 90.774% when pulling 546a8cf on aucampia:iwana-20230312T1013-eval_path into 3ff2218 on RDFLib:main.

@aucampia
Copy link
Member Author

I plan to merge this with no further review, as this just changes the function name in fairly well tested code.

@aucampia aucampia requested a review from a team March 12, 2023 09:30
@aucampia aucampia merged commit 8c48549 into RDFLib:main Mar 12, 2023
@aucampia aucampia deleted the iwana-20230312T1013-eval_path branch April 9, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants