Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default jsonld version to 1.1. autoformat for corresponding files. #2751

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

WhiteGobo
Copy link
Contributor

@WhiteGobo WhiteGobo commented Mar 23, 2024

jsonld version 1.1 seems to be needed as standard in some cases, see issue #2606
This change might raise some mypy warning because version parameter in jsonld.parse now annotated with float. During runtime this change shouldnt change any behaviour outside from the default version.
PR #2750 is required, or else the roundtrip test will fail.

Summary of changes

set default version of jsonld context and parser to version 1.1 Serializer doesnt have itself an option for this.
version now a parameter for the jsonldparser.parse
default versionnumber in context now shown
autoformat with black on jsonld parser

Checklis

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.(See above)
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

Coverage Status

coverage: 91.019% (+0.01%) from 91.009%
when pulling 461d7af on WhiteGobo:jsonlddefaultversion11Issue2606
into 27c81f0 on RDFLib:main.

@nicholascar nicholascar merged commit fb43b7a into RDFLib:main Apr 27, 2024
19 of 20 checks passed
@WhiteGobo WhiteGobo deleted the jsonlddefaultversion11Issue2606 branch November 28, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants