Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile debpendabot #2840

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Reconcile debpendabot #2840

merged 7 commits into from
Jul 24, 2024

Conversation

ashleysommer
Copy link
Contributor

Summary of changes

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
    • Considered adding an example in ./examples.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

dependabot bot and others added 6 commits July 24, 2024 14:18
Bumps [mypy](https://github.com/python/mypy) from 1.6.1 to 1.8.0.
- [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md)
- [Commits](python/mypy@v1.6.1...v1.8.0)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nicholas Car <[email protected]>
Co-authored-by: Edmond Chuc <[email protected]>
Bumps [black](https://github.com/psf/black) from 24.3.0 to 24.4.2.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@24.3.0...24.4.2)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [myst-parser](https://github.com/executablebooks/MyST-Parser) from 2.0.0 to 3.0.1.
- [Release notes](https://github.com/executablebooks/MyST-Parser/releases)
- [Changelog](https://github.com/executablebooks/MyST-Parser/blob/master/CHANGELOG.md)
- [Commits](executablebooks/MyST-Parser@v2.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: myst-parser
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ashley Sommer <[email protected]>
Bumps [types-setuptools](https://github.com/python/typeshed) from 69.5.0.20240513 to 71.1.0.20240723.
- [Commits](https://github.com/python/typeshed/commits)

---
updated-dependencies:
- dependency-name: types-setuptools
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nicholas Car <[email protected]>
Co-authored-by: Ashley Sommer <[email protected]>
@ashleysommer
Copy link
Contributor Author

This branch uses a new content-hash overriding the content-hash conflict that most of these PRs had.

@ashleysommer
Copy link
Contributor Author

Errors:

rdflib/query.py:160: error: Unused "type: ignore[type-var]" comment  [unused-ignore]
  rdflib/graph.py:1785: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/graph.py:1829: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/graph.py:2000: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/graph.py:2003: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/graph.py:2798: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/graph.py:2817: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/graph.py:2820: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/graph.py:2987: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/graph.py:2990: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/plugins/sparql/results/xmlresults.py:257: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/plugins/sparql/results/xmlresults.py:287: error: Unused "type: ignore" comment  [unused-ignore]
  rdflib/plugins/parsers/trix.py: note: In member "startElementNS" of class "TriXHandler":
  rdflib/plugins/parsers/trix.py:108: error: Incompatible types in assignment (expression has type "str", variable has type "None")  [assignment]
  rdflib/plugins/parsers/trix.py:108: error: Argument 1 to "getValue" of "AttributesImpl" has incompatible type "Tuple[str, str]"; expected "str"  [arg-type]
  rdflib/plugins/parsers/trix.py:113: error: Incompatible types in assignment (expression has type "str", variable has type "None")  [assignment]
  rdflib/plugins/parsers/trix.py:125: error: Incompatible types in assignment (expression has type "str", variable has type "None")  [assignment]
  rdflib/plugins/parsers/trix.py:125: error: Argument 1 to "getValue" of "AttributesImpl" has incompatible type "Tuple[str, str]"; expected "str"  [arg-type]
  rdflib/plugins/parsers/trix.py: note: In member "parse" of class "TriXParser":
  rdflib/plugins/parsers/trix.py:287: error: "ContentHandler" has no attribute "preserve_bnode_ids"  [attr-defined]
  rdflib/plugins/parsers/rdfxml.py: note: In member "startElementNS" of class "RDFXMLHandler":
  rdflib/plugins/parsers/rdfxml.py:184: error: No overload variant of "get" of "AttributesImpl" matches argument types "Tuple[str, str]", "None"  [call-overload]
  rdflib/plugins/parsers/rdfxml.py:184: note: Possible overload variants:
  rdflib/plugins/parsers/rdfxml.py:184: note:     def get(self, name: str, alternative: None = ...) -> Optional[str]
  rdflib/plugins/parsers/rdfxml.py:184: note:     def get(self, name: str, alternative: str) -> str
  rdflib/plugins/parsers/rdfxml.py:201: error: No overload variant of "get" of "AttributesImpl" matches argument types "Tuple[str, str]", "None"  [call-overload]
  rdflib/plugins/parsers/rdfxml.py:201: note: Possible overload variants:
  rdflib/plugins/parsers/rdfxml.py:201: note:     def get(self, name: str, alternative: None = ...) -> Optional[str]
  rdflib/plugins/parsers/rdfxml.py:201: note:     def get(self, name: str, alternative: str) -> str
  rdflib/plugins/parsers/rdfxml.py: note: In member "convert" of class "RDFXMLHandler":
  rdflib/plugins/parsers/rdfxml.py:280: error: Statement is unreachable  [unreachable]
  rdflib/plugins/parsers/rdfxml.py: note: In member "literal_element_start" of class "RDFXMLHandler":
  rdflib/plugins/parsers/rdfxml.py:593: error: Incompatible types in assignment (expression has type "str", variable has type "Tuple[str, str]")  [assignment]
  rdflib/plugins/parsers/rdfxml.py: note: In member "parse" of class "RDFXMLParser":
  rdflib/plugins/parsers/rdfxml.py:646: error: "ContentHandler" has no attribute "preserve_bnode_ids"  [attr-defined]

Looks like these are new, caused by the latest update to MyPy.

The unused-ignore are funny. Its now an error to put type: ignore on a line where the type does not need to be ignored 🤣

@coveralls
Copy link

Coverage Status

coverage: 91.04% (+0.001%) from 91.039%
when pulling b765634 on reconcile_debpendabot
into c9dc71e on main.

@ashleysommer ashleysommer merged commit 66f7925 into main Jul 24, 2024
20 of 22 checks passed
@ashleysommer ashleysommer deleted the reconcile_debpendabot branch July 24, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants