Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bias and more metadata in gradlib and tuned gemm #202

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Bias and more metadata in gradlib and tuned gemm #202

merged 11 commits into from
Sep 23, 2024

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented Sep 20, 2024

Using hipblaslt solutions with bias support for gemms with bias. Comparing them against rocblas with separate bias add for fair comparison.

Writing bias, in dtype, out dtype in the untuned and tuned file to reuse the same tuned csv.
dtypes can be overriden by the command line to tune for fp8

@charlifu
Copy link

charlifu commented Sep 20, 2024

I recall for fp16 gemm, rocblas solutions are also queried. Does this PR make the change for rocblas part of gradlib?

@gshtras
Copy link
Collaborator Author

gshtras commented Sep 20, 2024

I recall for fp16 gemm, rocblas solutions are also queried. Does this PR make the change for rocblas part of gradlib?

Only so that if a gemm is tuned with bias, times for rocblas are computed while adding bias separately.
All the rest rocblas remains the same, for gemms without bias it is often faster.

@gshtras gshtras merged commit 1f0d319 into main Sep 23, 2024
16 of 17 checks passed
@gshtras gshtras deleted the gradlib_bias branch September 23, 2024 19:02
gshtras added a commit that referenced this pull request Sep 23, 2024
* Adding bias to hipb_mm in gradlib. Expanding gradlib to tune based on bias and dtype captured from the actual capture run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants