Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rpdtracer import only when required #216

Merged
merged 8 commits into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/profiling/benchmark_latency.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import numpy as np
import torch
from rpdTracerControl import rpdTracerControl as rpd
from tqdm import tqdm

from vllm import LLM, SamplingParams
Expand All @@ -24,6 +23,7 @@ def main(args: argparse.Namespace):

@contextmanager
def rpd_profiler_context():
from rpdTracerControl import rpdTracerControl as rpd
llm.start_profile()
yield
llm.stop_profile()
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/profiling/benchmark_throughput.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import torch
import uvloop
from rpdTracerControl import rpdTracerControl as rpd
from tqdm import tqdm
from transformers import (AutoModelForCausalLM, AutoTokenizer,
PreTrainedTokenizerBase)
Expand Down Expand Up @@ -98,6 +97,7 @@ def run_vllm(

@contextmanager
def rpd_profiler_context():
from rpdTracerControl import rpdTracerControl as rpd
llm.start_profile()
yield
llm.stop_profile()
Expand Down
30 changes: 22 additions & 8 deletions vllm/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import torch.types
import yaml
from packaging.version import Version
from rpdTracerControl import rpdTracerControl
from typing_extensions import ParamSpec, TypeIs, assert_never

import vllm.envs as envs
Expand Down Expand Up @@ -208,6 +207,7 @@ def setup_environment_variables(filename):

def initialize_rpd_tracer(self, filename, nvtx):
try:
from rpdTracerControl import rpdTracerControl
rpd_trace.setup_environment_variables(filename)
rpdTracerControl.setFilename(name=filename, append=True)
return rpdTracerControl(nvtx=nvtx)
Expand All @@ -233,21 +233,35 @@ def create_file(filename):
print(f"An error occurred while creating the filename: {e}")


@lru_cache(maxsize=None)
def is_hipScopedMarker_available():
try:
from hipScopedMarker import hipScopedMarker
except ImportError:
hipScopedMarker = None
return hipScopedMarker is not None


class rpd_mark():

def __init__(self, name=None):
self.name = name

def __call__(self, func):
from hipScopedMarker import hipScopedMarker

@wraps(func)
def inner(*args, **kwds):
marker_name = self.name if self.name else f"{func.__name__}"
with hipScopedMarker(f"{marker_name}"):
return func(*args, **kwds)
if is_hipScopedMarker_available():
from hipScopedMarker import hipScopedMarker

return inner
@wraps(func)
def inner(*args, **kwds):
marker_name = self.name if self.name else f"{func.__name__}"
with hipScopedMarker(f"{marker_name}"):
return func(*args, **kwds)

return inner

else:
return func


class Device(enum.Enum):
Expand Down
3 changes: 2 additions & 1 deletion vllm/worker/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
from vllm.prompt_adapter.request import PromptAdapterRequest
from vllm.sequence import (ExecuteModelRequest, IntermediateTensors,
SequenceGroupMetadata, SequenceGroupMetadataDelta)
from vllm.utils import rpd_trace
from vllm.worker.cache_engine import CacheEngine
from vllm.worker.embedding_model_runner import EmbeddingModelRunner
from vllm.worker.enc_dec_model_runner import EncoderDecoderModelRunner
Expand Down Expand Up @@ -144,6 +143,8 @@ def __init__(
logger.info("Profiling enabled. Traces will be saved to: %s",
rpd_profiler_trace_dir)

from vllm.utils import rpd_trace

if self.rank == 0:
rpd_trace.create_file(filename=str(rpd_profiler_trace_dir))

Expand Down
Loading