Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix-enabled FA perf issue #239

Merged
merged 3 commits into from
Oct 22, 2024
Merged

prefix-enabled FA perf issue #239

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e11b9b2
prefix-enabled FA perf issue
seungrokj Oct 21, 2024
f9805ca
split ENC, DEC/ENC_DEC
seungrokj Oct 22, 2024
81ef957
lint
seungrokj Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions vllm/attention/backends/rocm_flash_attn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,11 +621,25 @@ def forward(

if prefill_meta := attn_metadata.prefill_metadata:
output = torch.empty_like(query)
(query_seq_start_loc, query_max_seq_len, key_seq_start_loc,
key_max_seq_len, seq_lens,
causal_mask) = _get_seq_len_block_table_args(
prefill_meta, attn_type)

# Prompt run.
# normal attention and DECODER
if attn_type == AttentionType.DECODER and (
kv_cache.numel() == 0 or prefill_meta.block_tables is None
or prefill_meta.block_tables.numel() == 0):
(query_seq_start_loc, query_max_seq_len, key_seq_start_loc,
key_max_seq_len, seq_lens,
causal_mask) = (prefill_meta.seq_start_loc,
prefill_meta.max_prefill_seq_len,
prefill_meta.seq_start_loc,
prefill_meta.max_prefill_seq_len,
attn_metadata.seq_lens, True)
# prefix-enabled attention and ENCODER/ENCODER_DECODER
else:
(query_seq_start_loc, query_max_seq_len, key_seq_start_loc,
key_max_seq_len, seq_lens,
causal_mask) = _get_seq_len_block_table_args(
prefill_meta, attn_type)
# Prompt run.
if kv_cache.numel() == 0 or prefill_meta.block_tables.numel() == 0:
# triton attention
Expand Down
Loading