Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aiter readme #400

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Aiter readme #400

merged 5 commits into from
Feb 3, 2025

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented Feb 3, 2025

Documenting steps required for Aiter support

Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the AITER master env variable to readme with on/off status?

Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please only keep the master nob in readme :)


```bash
VLLM_USE_AITER # Toggle the feature as a whole. When off, none of the following are enabled. Off by default, unless the docker image above is used.
VLLM_USE_AITER_MOE # Enable MoE AITER kernel. On by default.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

```bash
VLLM_USE_AITER # Toggle the feature as a whole. When off, none of the following are enabled. Off by default, unless the docker image above is used.
VLLM_USE_AITER_MOE # Enable MoE AITER kernel. On by default.
VLLM_USE_AITER_PAGED_ATTN # Enable AITER Paged Attention kernel. Off by default.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

VLLM_USE_AITER # Toggle the feature as a whole. When off, none of the following are enabled. Off by default, unless the docker image above is used.
VLLM_USE_AITER_MOE # Enable MoE AITER kernel. On by default.
VLLM_USE_AITER_PAGED_ATTN # Enable AITER Paged Attention kernel. Off by default.
VLLM_USE_AITER_LINEAR # Enable AITER GEMM kernels. On by default.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

VLLM_USE_AITER_MOE # Enable MoE AITER kernel. On by default.
VLLM_USE_AITER_PAGED_ATTN # Enable AITER Paged Attention kernel. Off by default.
VLLM_USE_AITER_LINEAR # Enable AITER GEMM kernels. On by default.
VLLM_USE_AITER_NORM # Enable AITER RMS Norm kernel. On by default.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

To get [AITER](https://github.com/ROCm/aiter) kernels support, follow the [Docker build steps](#Docker-manifest) using the [aiter_intergration_final](https://github.com/ROCm/vllm/tree/aiter_intergration_final) branch
There is a published release candidate image at `rocm/vllm-dev:nightly_aiter_intergration_final_20250130`

To enable the feature make sure the following environment is set: `VLLM_USE_AITER=1`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it on by default? Off by default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be explicit in the readme ;)

Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@gshtras gshtras merged commit 4e7e709 into main Feb 3, 2025
2 of 4 checks passed
@gshtras gshtras deleted the aiter-readme branch February 3, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants