-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aiter readme #400
Aiter readme #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add the AITER master env variable to readme with on/off status?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please only keep the master nob in readme :)
docs/dev-docker/README.md
Outdated
|
||
```bash | ||
VLLM_USE_AITER # Toggle the feature as a whole. When off, none of the following are enabled. Off by default, unless the docker image above is used. | ||
VLLM_USE_AITER_MOE # Enable MoE AITER kernel. On by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
docs/dev-docker/README.md
Outdated
```bash | ||
VLLM_USE_AITER # Toggle the feature as a whole. When off, none of the following are enabled. Off by default, unless the docker image above is used. | ||
VLLM_USE_AITER_MOE # Enable MoE AITER kernel. On by default. | ||
VLLM_USE_AITER_PAGED_ATTN # Enable AITER Paged Attention kernel. Off by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
docs/dev-docker/README.md
Outdated
VLLM_USE_AITER # Toggle the feature as a whole. When off, none of the following are enabled. Off by default, unless the docker image above is used. | ||
VLLM_USE_AITER_MOE # Enable MoE AITER kernel. On by default. | ||
VLLM_USE_AITER_PAGED_ATTN # Enable AITER Paged Attention kernel. Off by default. | ||
VLLM_USE_AITER_LINEAR # Enable AITER GEMM kernels. On by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
docs/dev-docker/README.md
Outdated
VLLM_USE_AITER_MOE # Enable MoE AITER kernel. On by default. | ||
VLLM_USE_AITER_PAGED_ATTN # Enable AITER Paged Attention kernel. Off by default. | ||
VLLM_USE_AITER_LINEAR # Enable AITER GEMM kernels. On by default. | ||
VLLM_USE_AITER_NORM # Enable AITER RMS Norm kernel. On by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit
docs/dev-docker/README.md
Outdated
To get [AITER](https://github.com/ROCm/aiter) kernels support, follow the [Docker build steps](#Docker-manifest) using the [aiter_intergration_final](https://github.com/ROCm/vllm/tree/aiter_intergration_final) branch | ||
There is a published release candidate image at `rocm/vllm-dev:nightly_aiter_intergration_final_20250130` | ||
|
||
To enable the feature make sure the following environment is set: `VLLM_USE_AITER=1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it on by default? Off by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be explicit in the readme ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it
Documenting steps required for Aiter support