Fix permission issues #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was due to incorrect positions of parameters passed to the `get_user_permission` function. Also fix error when anon user tries to access the myorganisation page.
yld-weng
commented
Feb 24, 2025
home/services/project.py
Outdated
| """Get user's highest role across project's organisations""" | ||
| """ | ||
| Get user's highest role across project's organisations | ||
| TODO: this assuming a project can be linked to multiple organisations, check if still the case |
There was a problem hiding this comment.
Is this still true?
There was a problem hiding this comment.
@yld-weng Thanks for this Yuliang. From my understanding, a project should only be linked to one org. But the PI (and their team) should have access to all projects/orgs who agree to share their data with us.
There was a problem hiding this comment.
Also just to clarify - all managers in a given organisation should have access to all of the org's projects.
yld-weng
commented
Feb 24, 2025
home/services/project.py
Outdated
| @@ -63,7 +66,7 @@ def can_edit(self, user: User, project: Project) -> bool: | |||
| if role == ROLE_ADMIN: | |||
| return True | |||
| elif role == ROLE_PROJECT_MANAGER: | |||
| permission = self.get_user_permission(project, user) | |||
| permission = self.get_user_permission(user, project) | |||
twinkarma
requested changes
Mar 4, 2025
… into fix/permissions
Logic inside the dispatch will come before the Mixin which isn't ideal if it is related to user authentication.
|
I have removed |
|
Made a PR to this branch in #166 to address various issues and add proper permissions to the survey service |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily addresses permission issues and includes some basic documentation.
Related issues: #93, #78, and #102 (fixed).