Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Platform Fix (JS) #32

Merged
merged 4 commits into from
Dec 22, 2019
Merged

Multi Platform Fix (JS) #32

merged 4 commits into from
Dec 22, 2019

Conversation

bonedaddy
Copy link
Collaborator

@bonedaddy bonedaddy commented Dec 21, 2019

Unfortunately the usage of the gogoproto options for some "niceties" when interacting with the protocol buffers from Golang was causing issues when generating the code in other languages. This PR removes the usage of the custom gogoproto options, but keeps compiling the go generated code using gogoproto.

In theory this should be compatible with previous versions of TxPB however I think because this "breaks" the way you interact with TxPB from go code, it warrants a major version bump. As such this commit also inits a go.mod at v2.

Additionally this overhauls how we generate the js gRPC client stubs such that they no longer use grpc-web and instead use grpc-node.

Closes #22

TODO:

  • Bullet point list of changes

@bonedaddy
Copy link
Collaborator Author

Looks like to properly do this, I need to regenerate the bindings for javascript without using grpc-web

@bonedaddy bonedaddy changed the title Multi Platform Fix Multi Platform Fix (JS) Dec 22, 2019
@bonedaddy bonedaddy merged commit ebd0b91 into master Dec 22, 2019
@bonedaddy bonedaddy deleted the multi branch December 22, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-Investigate GRPC Web Configuration
2 participants