Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs & Fix: modify neg_sampling into train_neg_sample_args in sequential docs and fix test error #1365

Merged
merged 3 commits into from
Jul 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/bert4rec.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='BERT4Rec', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/caser.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='Caser', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/core.rst
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='CORE', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/fdsa.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='FDSA', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/fossil.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='FOSSIL', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/gcsan.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='GCSAN', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/gru4rec.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='GRU4Rec', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/gru4recf.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='GRU4RecF', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/gru4reckg.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='GRU4RecKG', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
5 changes: 4 additions & 1 deletion docs/source/user_guide/model/sequential/hgn.rst
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ Write the following code to a python file, such as `run.py`

from recbole.quick_start import run_recbole

run_recbole(model='HGN', dataset='ml-100k')
parameter_dict = {
'train_neg_sample_args': None,
}
run_recbole(model='HGN', dataset='ml-100k', config_dict=parameter_dict)

And then:

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/hrm.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='HRM', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/ksr.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='KSR', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/lightsans.rst
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='LightSANs', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/narm.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='NARM', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/nextitnet.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='NextItNet', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/npe.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='NPE', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/repeatnet.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='RepeatNet', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/sasrec.rst
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='SASRec', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/sasrecf.rst
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='SASRecF', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/shan.rst
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='SHAN', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/sine.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='SINE', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/srgnn.rst
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='SRGNN', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
2 changes: 1 addition & 1 deletion docs/source/user_guide/model/sequential/stamp.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Write the following code to a python file, such as `run.py`
from recbole.quick_start import run_recbole

parameter_dict = {
'neg_sampling': None,
'train_neg_sample_args': None,
}
run_recbole(model='STAMP', dataset='ml-100k', config_dict=parameter_dict)

Expand Down
1 change: 1 addition & 0 deletions recbole/config/configurator.py
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,7 @@ def _set_default_parameters(self):
)

def _init_device(self):
self.final_config_dict["gpu_id"] = str(self.final_config_dict["gpu_id"])
gpu_id = self.final_config_dict["gpu_id"]
os.environ["CUDA_VISIBLE_DEVICES"] = gpu_id
import torch
Expand Down
2 changes: 1 addition & 1 deletion recbole/utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,6 @@ def forward(self, interaction):
flop_counter.uncalled_modules_warnings(uncalled_warnings)
flop_counter.tracer_warnings("none")
total_flops = 0
for op, flop in flop_counter.by_operator().items():
for _, flop in flop_counter.by_operator().items():
total_flops += flop
return total_flops