Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temp file name from error output #52

Open
MasterDuke17 opened this issue Oct 18, 2016 · 3 comments
Open

Remove temp file name from error output #52

MasterDuke17 opened this issue Oct 18, 2016 · 3 comments
Labels
whateverable Issues affecting the bot framework (and therefore all of the bots)

Comments

@MasterDuke17
Copy link
Collaborator

MasterDuke17 commented Oct 18, 2016 •
edited by AlexDaniel
Loading

E.g., Camelia returns this:
rakudo-moar f7770e: OUTPUT«not ok 1 - ␤␤# Failed test at <tmp> line 1␤# maximum relative tolerance: 1e-15␤# actual relative difference: 1␤»

while Committable6 returns this:
iBakeCake, ¦«2016.10»: not ok 1 - ␤␤# Failed test at /tmp/ALIDT91faL line 1␤# maximum relative tolerance: 1e-15␤# actual relative difference: 1 «exit code = 1»
@MasterDuke17 MasterDuke17 added all bots Issues affecting all (or most) of the bots whateverable Issues affecting the bot framework (and therefore all of the bots) labels Oct 18, 2016
@AlexDaniel AlexDaniel removed the all bots Issues affecting all (or most) of the bots label Oct 18, 2016
@AlexDaniel
Copy link
Member

As I see it, this also depends on #25.

Sure, we can mangle the output like camelia does, but it would be much better if we actually write it into <tmp> file in the current working directory :)

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jan 6, 2017
@AlexDaniel AlexDaniel removed the testneeded Issue is generally resolved but tests were not written yet label Mar 12, 2017
@AlexDaniel AlexDaniel added the blocked ☹ Underlying issue is outside this repo, a ticket was filed label Jul 21, 2017
@AlexDaniel
Copy link
Member

Blocked by #25.

AlexDaniel added a commit that referenced this issue Sep 29, 2017
@AlexDaniel
I ♥ systemd
845db2e 
This commit resolves many long-standing problems:

* Issue #25 (RESTRICTED setting) is resolved. Bots are still not fully
  secure, but now they are more secure that they've even been given
  that RESTRICTED setting is entirely useless
* Issue #52 (predictable filenames) is no longer blocked
* Issue #55 (sandboxable) is probably no longer relevant
* Issue #118 (ramfs for /tmp) now needs an update
* Issue #144 (bots leaving stuff behind) is resolved because every bot
  has its own /tmp
* Issue #183 (source ip issue) possibly has a systemd solution for it
* Issue #197 is tackled a little bit also because now there's a memory
  limit for every bot (3G for now, we can probably make it smaller)
* Issue #238 (e.g. forkbombs) is basically resolved, but needs a bit more work
* Moreover, there's now a watchdog that makes sure that bots come back
  online if something bad happens

Not that all of this wasn't possible without systemd, it's just that
it is so much easier now. Feel free to hate me as much as you want.
@AlexDaniel AlexDaniel removed the blocked ☹ Underlying issue is outside this repo, a ticket was filed label Sep 29, 2017
@AlexDaniel
Copy link
Member

Now we can simply write into any fixed file in /tmp and it won't conflict with other bots.

Bots for Testable are still not using systemd in any way, so maybe this is still blocked… but now there's less stuff to care about (e.g. we can have unpredictable names when running tests, that's ok).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whateverable Issues affecting the bot framework (and therefore all of the bots)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexDaniel @MasterDuke17